<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 4/1/2015 3:49 AM, Evgeniya Stepanova
wrote:<br>
</div>
<blockquote cite="mid:551BCD40.5010601@oracle.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
Hi Mandy!<br>
<br>
Thanks for looking at this<br>
One of the testlibrary classes used is depends on java.management.
Added tag @modules<br>
<br>
new webrev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eeistepan/8026043/webrev.01">http://cr.openjdk.java.net/~eistepan/8026043/webrev.01</a><br>
<br>
</blockquote>
<br>
Thanks. Looks okay to me.<br>
<br>
Nit: There are a few long lines that you may consider breaking them.<br>
No need for an updated webrev.<br>
<br>
Mandy<br>
<br>
<blockquote cite="mid:551BCD40.5010601@oracle.com" type="cite">
Thanks,<br>
Jane<br>
<br>
<div class="moz-cite-prefix">On 31.03.2015 19:25, Mandy Chung
wrote:<br>
</div>
<blockquote cite="mid:551ACA7E.8010502@oracle.com" type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
<div class="moz-cite-prefix">Does this need any @modules tag?<br>
<br>
Mandy<br>
<br>
On 3/31/15 7:10 AM, Evgeniya Stepanova wrote:<br>
</div>
<blockquote cite="mid:551AAAD1.90301@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
Hi all,<br>
<br>
Could you please review fix for 8026043? It is a regression
test for 8000831: Heap verification output
incorrect/incomplete. Test check that gc log contains expected
information<br>
Originally patch was performed by Filipp Zhinkin in [1] , but
review process was never finished.<br>
Test adapted to use current testlibrary functionality.<br>
<br>
bug: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8026043">https://bugs.openjdk.java.net/browse/JDK-8026043</a><br>
webrev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eeistepan/8026043/webrev.00/">http://cr.openjdk.java.net/~eistepan/8026043/webrev.00/</a><br>
[1] <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2013-October/008772.html">http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2013-October/008772.html</a><br>
<br>
Thanks,<br>
Jane<br>
<div class="moz-signature"><br>
</div>
</blockquote>
<br>
</blockquote>
<br>
<div class="moz-signature">-- <br>
<i>Evgeniya Stepanova</i></div>
</blockquote>
<br>
</body>
</html>