<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Jesper,<br>
<br>
Thank you very much for the review and your help!<br>
<br>
Thanks,<br>
Jane<br>
<div class="moz-cite-prefix">On 09.04.2015 16:30, Jesper Wilhelmsson
wrote:<br>
</div>
<blockquote cite="mid:55267EF8.5030807@oracle.com" type="cite">Looks
good!
<br>
Thanks for fixing this!
<br>
<br>
My only question mark is around the type cast for the atomics in
taskqueue.cpp. I don't see any other solution though as long as we
don't have atomics for uint.
<br>
If a Reviewer is OK with this, I say ship it!
<br>
<br>
Thanks,
<br>
/Jesper
<br>
<br>
<br>
Evgeniya Stepanova skrev den 9/4/15 14:30:
<br>
<blockquote type="cite">Hi,
<br>
<br>
Please review fix for JDK-6407976.
<br>
In some source files GC worker threads numbers are being stored
as
<br>
signed values and same values in other classes are being stored
as unsigned
<br>
values. Fix changed GC worker thread number to be uint.
<br>
<br>
bug: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-6407976">https://bugs.openjdk.java.net/browse/JDK-6407976</a>
<br>
webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~eistepan/6407976/webrev.00/">http://cr.openjdk.java.net/~eistepan/6407976/webrev.00/</a>
<br>
<br>
tested by running all hotspot tests on all platforms
<br>
<br>
<br>
Thanks,
<br>
Jane
<br>
<br>
//
<br>
</blockquote>
</blockquote>
<br>
<div class="moz-signature">-- <br>
<i>Evgeniya Stepanova</i></div>
</body>
</html>