<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Goetz,<br>
<br>
<div class="moz-cite-prefix">On 2015-04-21 10:20, Lindenmaier, Goetz
wrote:<br>
</div>
<blockquote
cite="mid:4295855A5C1DE049A61835A1887419CC2CFBFF75@DEWDFEMB12A.global.corp.sap"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 14 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">another include that’s
missing. This time it breaks aix only, would not have been
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">detected by non-pch
build </span><span style="font-family:Wingdings"
lang="EN-US">J</span><span lang="EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">taskqueue.hpp calls
Stack::push(), thus it must include stack.inline.hpp.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Compilation of
parallelScavenge/vmPSOperations.cpp failed.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Please review this tiny
change. I also please need a sponsor.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Egoetz/webrevs/8078243-pchBld2/webrev.01/">http://cr.openjdk.java.net/~goetz/webrevs/8078243-pchBld2/webrev.01/</a></span></p>
</div>
</blockquote>
<br>
I understand that this is an easy fix, but I don't want
stack.inline.hpp to be added to the hpp file. The preferred fix
would be extract the offending push function out of the
taskqueue.hpp file and put it in a new file called
taskqueue.inline.hpp. I created a RFE for that a couple of weeks
ago:<br>
<br>
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8076177">https://bugs.openjdk.java.net/browse/JDK-8076177</a> - Remove usage of
stack.inline.hpp functions from taskqueue.hpp<br>
<br>
Until someone takes care about 8076177, could you workaround the
compile error by including stack.inline.hpp in vmPSOperations.cpp?
Do you know what in vmPSOperations.cpp depends on taskqueue.hpp? I
can't find anything, but I see that we include
psScavenge.inline.hpp, which includes taskqueue.hpp via
psPromotionManager.inline.hpp and psPromotionManager.hpp. Maybe you
could workaround the problem by removing the "#include
.../psScavenge.inline.hpp" line, which isn't needed by
vmPSOperations.cpp?<br>
<br>
Thanks,<br>
StefanK<br>
<br>
<blockquote
cite="mid:4295855A5C1DE049A61835A1887419CC2CFBFF75@DEWDFEMB12A.global.corp.sap"
type="cite">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Best regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> Goetz.<o:p></o:p></span></p>
</div>
</blockquote>
<br>
</body>
</html>