<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 4/22/15 11:34 AM, Jon Masamitsu
wrote:<br>
</div>
<blockquote cite="mid:5537BF7C.2090003@oracle.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<br>
<br>
<div class="moz-cite-prefix">On 4/21/2015 1:56 PM, Derek White
wrote:<br>
</div>
<blockquote cite="mid:5536B981.80307@oracle.com" type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
<div class="moz-cite-prefix">Thanks Jon!<br>
<br>
On 4/21/15 1:23 PM, Jon Masamitsu wrote:<br>
</div>
<blockquote cite="mid:553687A0.8090802@oracle.com" type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
Derek,<br>
<br>
Thanks for fixing this.<br>
<br>
Fix looks good.<br>
<br>
What do you think about always making
testDynamicNumberOfGCThread()<br>
check for the uniprocessor case (as opposed to passing in a
flag to explicitly<br>
check it)? <br>
</blockquote>
This may not catch all of the failures. What I couldn't pin down
was why some 2, 3(!), or 4 core ARM machines would result in
defaulting ParallelGCThreads=1. Now these were embedded
machines, with potentially "odd" versions of linux, possibly
with "odd" errata. Or perhaps there was some dynamic differences
between "installed" and "on-line" cores.<br>
<br>
In any case the safest test seemed to be to force
ParallelGCThreads=1 and see if it works.<br>
</blockquote>
<br>
I don't think I said it right. What I meant was that
testDynamicNumberOfGCThread()<br>
should always test both cases (emulate_uniprocessor true and
false) instead of calling<br>
testDynamicNumberOfGCThread() twice, once with
emulate_uniprocessor true and once<br>
with emulate_uniprocessor false. Was that what you responded to?<br>
</blockquote>
<br>
Ah, OK. Thanks!<br>
<br>
<br>
- Derek<br>
<br>
</body>
</html>