<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Derek,<br>
<br>
Fix and test look good. Those parts are Reviewed.<br>
<br>
I don't know whether the TEST.group changes are correct or not.<br>
Someone who understand the rational for inclusion/exclusion should<br>
review those.<br>
<br>
Jon<br>
<br>
<br>
<div class="moz-cite-prefix">On 4/23/2015 2:55 PM, Derek White
wrote:<br>
</div>
<blockquote cite="mid:55396A3F.8050402@oracle.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<div class="moz-cite-prefix">2nd webrev:<br>
<br>
<tt>Please review this fix for: <br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8076995">https://bugs.openjdk.java.net/browse/JDK-8076995</a></tt><br>
<pre wrap="">Webrev:
<a href="http://cr.openjdk.java.net/%7Edrwhite/8076995/webrev.01/" moz-do-not-send="true" class="moz-txt-link-freetext">http://cr.openjdk.java.net/~drwhite/8076995/webrev.01/</a>
</pre>
<br>
Changes:<br>
<br>
- Updated TEST.groups to only run this test if G1, CMS, and
Parallel GCs are enabled.<br>
- Also searched for similar GC tests that specify a GC to use
and added to TESTS.groups:<br>
<ul>
<li>gc/TestSmallHeap.java</li>
<li>gc/logging/TestGCId.java</li>
<li>gc/TestCardTablePageCommits.java</li>
<li>gc/arguments/TestParallelHeapSizeFlags.java</li>
</ul>
- Responded to comments below.<br>
<br>
Did jprt run. Saw timeout, not sure if real or if it's one of
those "embedded tests don't quite fit" errors.<br>
Fail/kill comment: Targets failed. Target
linux_armvfpsflt_2.6-productEmb-c2-hotspot_servertest timedout.
<br>
<br>
- Derek<br>
<br>
On 4/21/15 1:23 PM, Jon Masamitsu wrote:<br>
</div>
<blockquote cite="mid:553687A0.8090802@oracle.com" type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
Derek,<br>
<br>
Thanks for fixing this.<br>
<br>
Fix looks good.<br>
<br>
What do you think about always making
testDynamicNumberOfGCThread()<br>
check for the uniprocessor case (as opposed to passing in a flag
to explicitly<br>
check it)? <br>
<br>
ForceDynamicNumberOfGCThreads is a diagnostic flag<br>
<br>
diagnostic(bool, ForceDynamicNumberOfGCThreads,
false, \<br>
"Force dynamic selection of the number of
" \<br>
"parallel threads parallel gc will use to aid
debugging") \<br>
<br>
so I think you need +UnlockDiagnosticVMOptions.<br>
<br>
Jon<br>
<br>
<div class="moz-cite-prefix">On 04/21/2015 06:53 AM, Derek White
wrote:<br>
</div>
<blockquote cite="mid:5536563F.4020806@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
<tt>Hi All,</tt><tt><br>
</tt><tt><br>
</tt><tt>Please review this fix for: <br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8076995">https://bugs.openjdk.java.net/browse/JDK-8076995</a></tt><br>
<pre wrap="">Webrev:
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Edrwhite/8076995/webrev.00/">http://cr.openjdk.java.net/~drwhite/8076995/webrev.00/</a>
Summary:
Part 1 is a test bug that tries to run G1 on embedded SE builds. Not changed by this webrev.
Part two is assertion failure that is being fixed by this webrev.
This is a fix for bug that triggered an assert when running CMS on very
small machines - 1 core x86, or 1-4 core ARM. This may seem unlikely but
can easily happen when running virtual instances.
Failure stack traces also show bug crashing printing a stack trace, but this is being tracked in another bug.
Thanks,
- Derek
</pre>
<tt><br>
</tt><tt><br>
</tt><tt><br>
</tt>
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>