<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi Bengt,<br>
<br>
On 4/27/15 4:04 AM, Bengt Rutisson wrote:<br>
</div>
<blockquote cite="mid:553DED8E.7070706@oracle.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<br>
Hi Derek,<br>
<br>
<div class="moz-cite-prefix">On 2015-04-23 23:55, Derek White
wrote:<br>
</div>
<blockquote cite="mid:55396A3F.8050402@oracle.com" type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
<div class="moz-cite-prefix">2nd webrev:<br>
<br>
<tt>Please review this fix for: <br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8076995">https://bugs.openjdk.java.net/browse/JDK-8076995</a></tt><br>
<pre wrap="">Webrev:
<a href="http://cr.openjdk.java.net/%7Edrwhite/8076995/webrev.01/" moz-do-not-send="true" class="moz-txt-link-freetext">http://cr.openjdk.java.net/~drwhite/8076995/webrev.01/</a>
</pre>
<br>
Changes:<br>
<br>
- Updated TEST.groups to only run this test if G1, CMS, and
Parallel GCs are enabled.<br>
</div>
</blockquote>
<br>
OK.<br>
<br>
<blockquote cite="mid:55396A3F.8050402@oracle.com" type="cite">
<div class="moz-cite-prefix"> - Also searched for similar GC
tests that specify a GC to use and added to TESTS.groups:<br>
<ul>
<li>gc/TestSmallHeap.java</li>
<li>gc/logging/TestGCId.java</li>
<li>gc/TestCardTablePageCommits.java</li>
<li>gc/arguments/TestParallelHeapSizeFlags.java</li>
</ul>
</div>
</blockquote>
<br>
I think I would prefer this as a separate change. I'm not very
good with TEST.groups, but it looks like your suggested changes
are correct. However, I would prefer the get more attention to
that change and thus it would be better to send it out as a
separate review.<br>
<br>
Thanks,<br>
Bengt</blockquote>
<br>
I read this as a request to split out the changes in TEST.groups for
the other tests to a separate bug, review, and checkin. Is that what
you meant? But I've seen some fancy partial reviews floating around,
so maybe I misunderstood.<br>
<br>
Thanks!<br>
<br>
 - Derek<br>
</body>
</html>