<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Derek,<br>
<br>
Sorry for the late comment.<br>
<br>
Adding needs_XXXgc groups was a temporary solution for the period
when jtreg didn't support @requires.<br>
Those groups are not used anymore in our nightly runs and will be
removed soon. <br>
<br>
The more proper way to specify that a test is not applicable for a
certain collector is adding @requires tag.<br>
Like:<br>
* @requires vm.gc == "G1" | vm.gc == null<br>
or<br>
if a test use all collectors:<br>
* @requires vm.gc=="null"<br>
<br>
Thanks,<br>
Dima<br>
<br>
<div class="moz-cite-prefix">On 29.04.2015 18:00, Derek White wrote:<br>
</div>
<blockquote cite="mid:5540F209.9040700@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<div class="moz-cite-prefix">Thanks Eric!<br>
<br>
On 4/29/15 10:44 AM, Eric Caspole wrote:<br>
</div>
<blockquote cite="mid:5540EE43.6060101@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
Hi Derek,<br>
Looks good to me.<br>
And now I learned how TEST.groups works ;)<br>
Eric<br>
<br>
<br>
<div class="moz-cite-prefix">On 4/28/2015 5:31 PM, Derek White
wrote:<br>
</div>
<blockquote cite="mid:553FFC31.8030101@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
Please review this simple for GC tests that require certain
collectors (e.g. shouldn't run in embedded).<br>
<br>
Certain GC regression tests require specific collectors to be
enabled in the JVM (by using -XX:+UseParallelGC, etc). But
these tests were not listed in TEST.groups.<br>
<br>
This webrev adds the following tests to the appropriate
needs_g1gc, needs_serialgc, needs_parallelgc, and needs_cmsgc
lists.
<ul>
<li>gc/TestSmallHeap.java</li>
<li>gc/TestCardTablePageCommits.java</li>
<li>gc/arguments/TestParallelHeapSizeFlags.java
gc/ergonomics/TestDynamicNumberOfGCThreads.java</li>
<li>gc/logging/TestGCId.java</li>
</ul>
CR:<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8078673">https://bugs.openjdk.java.net/browse/JDK-8078673</a><br>
<br>
Webrev:<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Edrwhite/8078673/webrev.00/">http://cr.openjdk.java.net/~drwhite/8078673/webrev.00/</a><br>
<br>
Testing: <br>
JPRT<br>
<br>
Thanks,<br>
- Derek<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>