<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Jungwoo,<br>
<br>
<div class="moz-cite-prefix">On 2015-04-29 23:46, Jungwoo Ha wrote:<br>
</div>
<blockquote
cite="mid:CA+n_jhg4JaTsJv-1WOpHZGpsWavaGsy+A8UbAAHDx9fqc4giQA@mail.gmail.com"
type="cite">
<div dir="ltr">Oops. I meant to copy BUG-8079091
<div>
<div><a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ejwha/8079091/webrev.00/">http://cr.openjdk.java.net/~jwha/8079091/webrev.00/</a></div>
</div>
<div><br>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Apr 29, 2015 at 2:40 PM,
Jungwoo Ha <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:jwha@google.com" target="_blank">jwha@google.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div>BUG: <a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8079091"
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8079091</a><br>
</div>
Webrev: <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ejwha/8075288/webrev.00/"
target="_blank">http://cr.openjdk.java.net/~jwha/8075288/webrev.00/</a><br>
<div><br>
</div>
<div>Can someone sponsor this change?</div>
<div>I've seen ~3% speed up on DaCapo benchmarks. (results
attached on the bug page.)</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
<br>
I'm having a hard time believing this claim. Could you provide JVM
flags that you used so that we can test this?<br>
<br>
<blockquote
cite="mid:CA+n_jhg4JaTsJv-1WOpHZGpsWavaGsy+A8UbAAHDx9fqc4giQA@mail.gmail.com"
type="cite">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div>Regardless of the speed up, I think the changes are
straight-forward improvement.</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
<br>
I agree. This is a nice cleanup, irrespective of any potential
performance gains.<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~jwha/8079091/webrev.00/src/share/vm/memory/metaspace.cpp.udiff.html">http://cr.openjdk.java.net/~jwha/8079091/webrev.00/src/share/vm/memory/metaspace.cpp.udiff.html</a><br>
<br>
-BlockFreelist::BlockFreelist() : _dictionary(NULL) {}<br>
+BlockFreelist::BlockFreelist()<br>
+ : _dictionary(new BlockTreeDictionary()) {<br>
+ assert(_dictionary != NULL, "Failed to allocate
BlockTreeDictionary");<br>
+}<br>
<br>
No need to NULL check CHeapObj allocations, since the JVM will exit
if it failed to get memory. See AllocateHeap:<br>
if (p == NULL && alloc_failmode ==
AllocFailStrategy::EXIT_OOM) {<br>
vm_exit_out_of_memory(size, OOM_MALLOC_ERROR, "AllocateHeap");<br>
}<br>
<br>
Thanks,<br>
StefanK<br>
<br>
<blockquote
cite="mid:CA+n_jhg4JaTsJv-1WOpHZGpsWavaGsy+A8UbAAHDx9fqc4giQA@mail.gmail.com"
type="cite">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div><br>
</div>
<div>--</div>
<div>Jungwoo Ha</div>
<div><br>
</div>
<div><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>