<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<br>
<div class="moz-cite-prefix">On 4/29/2015 11:09 PM, Jungwoo Ha
wrote:<br>
</div>
<blockquote
cite="mid:CA+n_jhjPN7KouhhDApc5miZkBGZ3oDwFSYnp0HLbYooMpb4BGg@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span
class="">
<blockquote class="gmail_quote" style="margin:0px 0px
0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>
</blockquote>
</span>
That style is my doing and my preference. There remains
differing opinions in the<br>
group on the style and some consider the accessors wasted
effort but I find them<br>
useful often enough to prefer them.<br>
<br>
Jon<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>
</blockquote>
</blockquote>
<div><br>
</div>
<div>I saw this after reading runtime thread. Things are
getting confused.</div>
<div>We can do</div>
<div><br>
</div>
<div>BlockFreelist *dictionary() { return &_dictionary;
}</div>
<div><br>
</div>
<div>and keep dictionary()->XXX</div>
<div>This is actually consistent with _humongous_blocklist.</div>
<div><br>
</div>
<div><a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ejwha/8079091/webrev.01">http://cr.openjdk.java.net/~jwha/8079091/webrev.01</a><br>
</div>
<div>current one has </div>
<div>
<div>BlockFreelist &dictionary() { return _dictionary;
}</div>
</div>
<div><br>
</div>
<div>and changed it to dictionary().XXX</div>
</div>
</div>
</div>
</blockquote>
<br>
Jungwoo,<br>
<br>
Sorry for the differing suggestions on our part. I think Kim's
point<br>
was to not have the accessors. I vote to (1) keep the accessors
(which<br>
are currently there) and use (2)<br>
<br>
<blockquote type="cite">
<div>BlockFreelist *dictionary() { return &_dictionary; }</div>
</blockquote>
<br>
and the style dictionary()->XXX (to minimize changes).<br>
<br>
Kim,<br>
<br>
How about we let Jungwoo integrate with the style (1) and<br>
(2) I outline above so he is not caught in the middle. You<br>
and I can talk about it on the side.<br>
<br>
Jon<br>
<br>
<br>
<blockquote
cite="mid:CA+n_jhjPN7KouhhDApc5miZkBGZ3oDwFSYnp0HLbYooMpb4BGg@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div><br>
</div>
<div>Whichever you guys prefer...</div>
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>