<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Jungwoo,<br>
<br>
On 2015-04-30 15:33, Jungwoo Ha wrote:<br>
<blockquote
cite="mid:CA+n_jhh9G83yY_Ajw_PqnSiaHrh-Q7s2Ff=H7uDjfViZLaJn6A@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"><span class=""><br>
</span> I agree. This is a nice cleanup, irrespective of
any potential performance gains.<br>
<br>
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ejwha/8079091/webrev.00/src/share/vm/memory/metaspace.cpp.udiff.html"
target="_blank">http://cr.openjdk.java.net/~jwha/8079091/webrev.00/src/share/vm/memory/metaspace.cpp.udiff.html</a><br>
<br>
-BlockFreelist::BlockFreelist() : _dictionary(NULL) {}<br>
+BlockFreelist::BlockFreelist()<br>
+ : _dictionary(new BlockTreeDictionary()) {<br>
+ assert(_dictionary != NULL, "Failed to allocate
BlockTreeDictionary");<br>
+}<br>
<br>
No need to NULL check CHeapObj allocations, since the
JVM will exit if it failed to get memory. See
AllocateHeap:<br>
if (p == NULL && alloc_failmode ==
AllocFailStrategy::EXIT_OOM) {<br>
vm_exit_out_of_memory(size, OOM_MALLOC_ERROR,
"AllocateHeap");<br>
}<br>
<br>
</div>
</blockquote>
<div><br>
</div>
<div><a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ejwha/8079091/webrev.02/">http://cr.openjdk.java.net/~jwha/8079091/webrev.02/</a><br>
</div>
<div><br>
</div>
<div>That part is taken care of on webrev.02. </div>
<div>The conversation is also happening at runtime mailing
list as Kim suggested to pass it to runtime.</div>
</div>
</div>
</div>
</blockquote>
<br>
Please don't split up a review request that way in the future. It
would have been enough to CC the hotspot-runtime-dev list.<br>
<br>
I'll leave the rest of my comments on that list.<br>
<br>
Thanks,<br>
StefanK<br>
<br>
<blockquote
cite="mid:CA+n_jhh9G83yY_Ajw_PqnSiaHrh-Q7s2Ff=H7uDjfViZLaJn6A@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div>I think the general agreement is on using webrev.02. </div>
<div><br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>