<div dir="ltr">Thanks for the review of the patch for 8-dev (from the ticket), Staffan.<div><br></div><div>Sorry for the delay in getting the official webrev out -- it took me a while to first get set up with an hs9 repo (thanks Jon!) and then get my openjdk credentials updated (thanks Mark!).<div><br></div><div>Here's the webrev against hs9 for official review:-</div><div><br></div><div><a href="http://cr.openjdk.java.net/~ysr/JDK-8080345/webrev.00/">http://cr.openjdk.java.net/~ysr/JDK-8080345/webrev.00/</a><br></div><div><br></div><div>I built and tested the change (on both 8-dev whose patch was attached with the original bug, as well as this with hs9) and verified that the counter value for generations, in the perfdata file, was now 2 instead of the previous 3.</div><div><br></div><div>thanks!</div><div>-- ramki</div><div><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, May 18, 2015 at 1:22 AM, Staffan Larsen <span dir="ltr"><<a href="mailto:staffan.larsen@oracle.com" target="_blank">staffan.larsen@oracle.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Looks like a good patch to me.<span class="HOEnZb"><font color="#888888"><div><br></div><div>/Staffan</div></font></span><div><div class="h5"><div><br><div><blockquote type="cite"><div>On 14 maj 2015, at 18:12, Srinivas Ramakrishna <<a href="mailto:ysr1729@gmail.com" target="_blank">ysr1729@gmail.com</a>> wrote:</div><br><div><div dir="ltr"><a href="https://bugs.openjdk.java.net/browse/JDK-8080345" style="font-size:13px" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8080345</a><br><div><br></div><div><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 13, 2015 at 1:08 PM, Srinivas Ramakrishna <span dir="ltr"><<a href="mailto:ysr1729@gmail.com" target="_blank">ysr1729@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div>With perm gen going away (and being replaced by metaspace) in JDK 8, it makes sense that the counter</div><div>sun.gc.policy.generations should be "2", rather than "3". However, in JDK 8 that counter still says 3.</div><div>As I understand, the intention was that this counter would allow you to (for example) know the range of</div><div>the sun.gc.generation.$num.* counters describing each of $num < sun.gc.policy.generations in the heap.</div><div>Recall that the erstwhile perm gen in JDK 7 used to be synonymous with sun.gc.generation.2, but the</div><div>JDK 8 avatars are now sun.gc.metaspace and sun.gc.compressedclassspace.</div><div><br></div><div>The fix is simple, and I can submit a patch. Is there an existing bug for this?</div><div><br></div><div>thanks!</div><div>-- ramki</div>
</div>
</blockquote></div><br></div></div>
</div></blockquote></div><br></div></div></div></div></blockquote></div><br></div></div></div>