<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello,<br>
<br>
Please review this change for bug:<br>
<a id="key-val" rel="4832557"
href="https://bugs.openjdk.java.net/browse/JDK-8129108">JDK-8129108:</a>
nmethod related crash in CM<br>
<br>
There is an assertion failure with fastdebug build with test <i>nsk.coverage.arguments.arguments002.arguments002</i>.<br>
This failure occurs when CMSCollector::_should_unload_classes is
false and the _roots_scanning_options does <br>
not contain SO_AllCodeCache:<br>
<pre># Internal Error (hotspot/src/share/vm/gc/cms/concurrentMarkSweepGeneration.cpp:4472), pid=16267, tid=0xf36ffb70
# assert(_collector->should_unload_classes() ||
(_collector->CMSCollector::roots_scanning_options() &
GenCollectedHeap::SO_AllCodeCache)) failed: if we didn't scan the code
cache, we have to be ready to drop nmethods with expired weak oops
</pre>
This problem was exposed with the fix of<a id="key-val"
rel="4786055"
href="https://bugs.openjdk.java.net/browse/JDK-8085965">
JDK-8085965:</a> VM hangs in C2Compiler, <br>
that disables CMSClassUnloadingEnabled when -Xnoclassgc or
-XX:-ClassUnloading <br>
are specified on the command line. <br>
<br>
CMSCollector::_roots_scanning_options option should contain
SO_AllCodeCache to ensure <br>
that we scan code cache when we are not unloading classes.<br>
<br>
Webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~poonam/8129108/webrev/">http://cr.openjdk.java.net/~poonam/8129108/webrev/</a><br>
Testing: JPRT, testcase <i>nsk.coverage.arguments.arguments002.arguments002</i><br>
<br>
Thanks,<br>
Poonam<br>
<br>
</body>
</html>