<html><head><style>body{font-family:Helvetica,Arial;font-size:13px}</style></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">Thomas,</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">It looks good. Only question I have is whether the change that sets filler_array_max_size based on the G1 heap region size has already gone in or not (as I couldn’t find it).</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">Tony</div> <br><p class="airmail_on" style="color:#000;">On June 24, 2015 at 5:40:33 AM, Thomas Schatzl (<a href="mailto:thomas.schatzl@oracle.com">thomas.schatzl@oracle.com</a>) wrote:</p> <blockquote type="cite" class="clean_bq"><span><div><div></div><div>Hi all,
<br>
<br> can I have reviews for this small bugfix that got exposed with latest
<br>changes in JDK-8042668?
<br>
<br>With that change, we cannot assume that only one object is required to
<br>fill a given memory range, as filler_array_max_size is actually 512k
<br>with G1 now on 32 bit systems (i.e. typically you get 1M regions).
<br>
<br>The change just removes the #ifdef __LP64 and fixes the comment.
<br>
<br>The problem itself actually only got exposed with the upcoming change
<br>JDK-8129558, where GCBasher acts as a good reproducable test case.
<br>
<br>CR:
<br>https://bugs.openjdk.java.net/browse/JDK-8129573
<br>
<br>Webrev:
<br>http://cr.openjdk.java.net/~tschatzl/8129573/webrev
<br>
<br>Testing:
<br>JPRT (running gcbasher + containing JDK-8129558)
<br>
<br>Thanks,
<br> Thomas
<br>
<br>
<br>
<br></div></div></span></blockquote> <div id="bloop_sign_1435158624540947968" class="bloop_sign"><div style="font-family:helvetica,arial;font-size:13px"><div>-----</div><div><br></div><div>Tony Printezis | JVM/GC Engineer / VM Team | Twitter</div><div><br></div><div>@TonyPrintezis</div><div><a href="mailto:tprintezis@twitter.com">tprintezis@twitter.com</a></div><div><br></div></div></div></body></html>