<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Please review this partial fix for GC
tests that require certain collectors (e.g. shouldn't run in
embedded). <br>
<br>
This is an updated webrev to account for Leonid's fix for
"8079134: [TESTBUG] Remove applicable_*gc and needs_*gc groups
from TEST.groups", which removed a pile of TEST.groups lists
including needs_gc, needs_serialgc, needs_parallelgc, and
needs_cmsgc.<br>
<br>
Now the fix simply updates the needs_g1gc list in TEST.groups and
adds appropriate "@requires vm.gc" annotations to a few GC tests.<br>
<br>
Note that the "@requires vm.gc" changes are <i>almost</i> purely
documentary. These are ProcessBuilder-based tests, so any
"-XX:+UsexxxGC" flags passed in by jtreg are ignored. It's very
confusing, as well as unnecessary, for a jtreg run specifying
-XX:+UseG1GC to be running a test that then replaces the flag with
"-XX:+UseParallelGC" (etc).<br>
<br>
<b>
CR:</b><br>
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8078673">https://bugs.openjdk.java.net/browse/JDK-8078673</a><br>
<br>
<b>
Webrev:</b><br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~drwhite/8078673/webrev.03/">http://cr.openjdk.java.net/~drwhite/8078673/webrev.03/</a><br>
<br>
<b>
Testing:</b><br>
JPRT<br>
<br>
<b>Open review comments:</b><br>
David H: Your last comments on this subject requested changes to
the "needs_gc" list, which has been removed by 8079134.<br>
<br>
Kim and Jesper: I agree with your comments about wanting some
better for both testing multiple GCs and dealing with SE Embedded
properly in the testing infrastructure. This webrev is simply a
good fix within the existing infrastructure.<br>
<br>
Thanks,<br>
- Derek<br>
<br>
On 4/29/15 5:03 PM, Kim Barrett wrote:<br>
</div>
<blockquote
cite="mid:47A58D96-A29E-44B4-84EE-F8FBA162B4C4@oracle.com"
type="cite">
<pre wrap="">On Apr 29, 2015, at 4:38 PM, Jesper Wilhelmsson <a class="moz-txt-link-rfc2396E" href="mailto:jesper.wilhelmsson@oracle.com"><jesper.wilhelmsson@oracle.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
Hi,
There are tests like hotspot/test/gc/g1/TestShrinkAuxiliaryData**.java where there is a base class that provides the test and a bunch of test classes that only starts the base test with different arguments. This case would be similar but slightly more ugly since the actual code would be the same and trigger the same base test, but with different @requires in the comment above the test.
I'm not sure it would help though. What we really would need here is a @requires that could check the host name or the hardware platform or OS.
</pre>
</blockquote>
<pre wrap="">
@requires has os.{name, family, arch, simpleArch} properties that can be tested. But I’m not sure any of those are really right for testing for “embedded system” (whatever that actually means).
</pre>
<blockquote type="cite">
<pre wrap="">Kim Barrett skrev den 29/4/15 20:35:
</pre>
<blockquote type="cite">
<pre wrap="">On Apr 29, 2015, at 2:06 PM, Derek White <a class="moz-txt-link-rfc2396E" href="mailto:derek.white@oracle.com"><derek.white@oracle.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
So most of these tests use ProcessBuilder to specify a command line, and explicitly mention a GC to use. A single test might actually run each collector (gc/logging/TestGCId, for example). Does @requires matter in this case?
Oh, maybe they should all have @requires vm.gc=="null", becuase the actual test is ignoring GC passed in by the test harness GC and running as a separate process anyway. It's misleading if the harness said UseG1GC and the test was actually running UseParallelGC, for example.
</pre>
</blockquote>
<pre wrap="">
That’s one solution. A different solution would be to clone into multiple tests, one for each relevant collector, where the vm.gc can be “null” or the corresponding collector. That cloning is kind of ugly though; it’s too bad there can only be one @requires constraint per test, rather than per @run line or the like. But we didn’t get any traction with such a suggestion: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/CODETOOLS-7901090">https://bugs.openjdk.java.net/browse/CODETOOLS-7901090</a>.
</pre>
<blockquote type="cite">
<pre wrap="">FYI, it sounds like my original problem does require the exclude lists to keep the embedded JVM from running GC tests that it shouldn't.
</pre>
</blockquote>
<pre wrap="">
I’m not sure how to address this problem. For example, we don’t want to exclude TestSmallHeap.java on embedded JVMs, we just want to exclude its sub-cases that would attempt to use a gc that isn’t supported.
</pre>
</blockquote>
</blockquote>
<pre wrap="">
</pre>
</blockquote>
<br>
</body>
</html>