<html><head><style>body{font-family:Helvetica,Arial;font-size:13px}</style></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">Bengt and Ramki,</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">ShipIt</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">(FWIW, I had already reviewed it for Ramki internally but I did go over the webrev one more time)</div> <br><p class="airmail_on" style="color:#000;">On September 1, 2015 at 9:12:43 AM, Bengt Rutisson (<a href="mailto:bengt.rutisson@oracle.com">bengt.rutisson@oracle.com</a>) wrote:</p> <blockquote type="cite" class="clean_bq"><span><div><div></div><div>
<br>Hi everyone,
<br>
<br>Could I have a couple of reviews for this patch contributed by Ramki?
<br>
<br>http://cr.openjdk.java.net/~brutisso/8133818/webrev.00/
<br>https://bugs.openjdk.java.net/browse/JDK-8133818
<br>
<br>This changes the log format to print Cleaners separately from
<br>PhantomReferences.
<br>
<br>Old logging:
<br>
<br>#0: [PhantomReference, 0 refs, 0 refs, 0,0000433 secs]
<br>
<br>New logigng:
<br>
<br>#0: [PhantomReference, 0 refs, 0,0000797 secs]#0: [Cleaners, 0 refs,
<br>0,0000527 secs]
<br>
<br>It also adds the number of references processed for the JNI Weak
<br>References section.
<br>
<br>Old logging:
<br>
<br>#0: [JNI Weak Reference, 0,0000211 secs]
<br>
<br>New logging:
<br>
<br>#0: [JNI Weak Reference, 0 refs, 0,0000401 secs]
<br>
<br>Here are full log entry examples with -XX:+PrintGCDetails
<br>-XX:+PrintReferenceGC:
<br>
<br>Old logging:
<br>
<br>#0: [GC (System.gc()) #0: [SoftReference, 0 refs, 0,0000713 secs]#0:
<br>[WeakReference, 8 refs, 0,0000306 secs]#0: [FinalReference, 7 refs,
<br>0,0000445 secs]#0: [PhantomReference, 0 refs, 0 refs, 0,0000433 secs]#0:
<br>[JNI Weak Reference, 0,0000211 secs][PSYoungGen: 7741K->912K(150016K)]
<br>7741K->920K(493056K), 0,0053059 secs] [Times: user=0,05 sys=0,00
<br>real=0,00 secs]
<br>
<br>
<br>New logging:
<br>
<br>#0: [GC (System.gc()) #0: [SoftReference, 0 refs, 0,0001244 secs]#0:
<br>[WeakReference, 8 refs, 0,0001069 secs]#0: [FinalReference, 5 refs,
<br>0,0001086 secs]#0: [PhantomReference, 0 refs, 0,0000797 secs]#0:
<br>[Cleaners, 0 refs, 0,0000527 secs]#0: [JNI Weak Reference, 0 refs,
<br>0,0000401 secs][PSYoungGen: 2580K->768K(150016K)] 2580K->776K(493056K),
<br>0,0130553 secs] [Times: user=0,16 sys=0,01 real=0,01 secs]
<br>
<br>
<br>Unless there are larger changes suggested to this patch I will push this
<br>with Ramki as author.
<br>
<br>Thanks,
<br>Bengt
<br>
<br></div></div></span></blockquote> <div id="bloop_sign_1441126306415001856" class="bloop_sign"><div style="font-family:helvetica,arial;font-size:13px"><div>-----</div><div><br></div><div>Tony Printezis | JVM/GC Engineer / VM Team | Twitter</div><div><br></div><div>@TonyPrintezis</div><div><a href="mailto:tprintezis@twitter.com">tprintezis@twitter.com</a></div><div><br></div></div></div></body></html>