<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
Hi Thomas,<br>
<br>
<blockquote cite="mid:5602948F.60800@oracle.com" type="cite">
<div class="moz-forward-container"><br>
<br>
-------- Forwarded Message --------
<table class="moz-email-headers-table" border="0"
cellpadding="0" cellspacing="0">
<tbody>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Subject:
</th>
<td>Re: RFR: JDK-8136991: [REDO] Additional number of
processed references printed with -XX:+PrintReferenceGC
after JDK-8047125</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Date:
</th>
<td>Wed, 23 Sep 2015 11:31:23 +0200</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">From:
</th>
<td>Thomas Schatzl <a moz-do-not-send="true"
class="moz-txt-link-rfc2396E"
href="mailto:thomas.schatzl@oracle.com"><thomas.schatzl@oracle.com></a></td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">To: </th>
<td>Bengt Rutisson <a moz-do-not-send="true"
class="moz-txt-link-rfc2396E"
href="mailto:bengt.rutisson@oracle.com"><bengt.rutisson@oracle.com></a></td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">CC: </th>
<td><a moz-do-not-send="true"
class="moz-txt-link-abbreviated"
href="mailto:hotspot-gc-dev@openjdk.java.net">hotspot-gc-dev@openjdk.java.net</a>
<a moz-do-not-send="true" class="moz-txt-link-rfc2396E"
href="mailto:hotspot-gc-dev@openjdk.java.net"><hotspot-gc-dev@openjdk.java.net></a></td>
</tr>
</tbody>
</table>
<br>
<br>
<pre>Hi Bengt,
On Wed, 2015-09-23 at 10:33 +0200, Bengt Rutisson wrote:
> Forgot to say that there is a diff compared to the previous version here:
> <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Ebrutisso/8136991/webrev.02-03-diff/">http://cr.openjdk.java.net/~brutisso/8136991/webrev.02-03-diff/</a>
the regexp in the test is not correct for product mode, as the number
of references is not printed for JNI weak references there.
Line
48 "#[0-9]+: \\[JNI Weak Reference, [0-9]+ refs, [0-9]+\\.[0-9]+
secs\\]");
should be
48 "#[0-9]+: \\[JNI Weak Reference, [[0-9]+ refs, ]?[0-9]+\
\.[0-9]+ secs\\]");
I think to optionally match the number of refs for JNI weak references.
Otherwise one could make the regexp dependent on the build type it is
run (using Platform.isDebug()).</pre>
</div>
</blockquote>
<br>
<br>
Good catch! I went for the optional count. <br>
<br>
Updated webrev:<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~brutisso/8136991/webrev.04/">http://cr.openjdk.java.net/~brutisso/8136991/webrev.04/</a><br>
<br>
Only the test has been changed since the last webrev.<br>
<br>
Thanks,<br>
Bengt<br>
<br>
<blockquote cite="mid:5602948F.60800@oracle.com" type="cite">
<div class="moz-forward-container">
<pre>
Thanks,
Thomas
</pre>
<br>
</div>
<br>
</blockquote>
<br>
</body>
</html>