<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<br>
<div class="moz-cite-prefix">On 11/4/2015 9:33 AM, Jungwoo Ha wrote:<br>
</div>
<blockquote
cite="mid:CA+n_jhiSJqr5ec9rBM0p34wK+CX0WyYPwoEp+jd5wLSmA4i0sg@mail.gmail.com"
type="cite">
<div dir="ltr">Unfortunately, we cannot provide the test publicly.
<div>But we do have internal tests that triggers this bug, and
got fixed with this patch.</div>
</div>
</blockquote>
<br>
Can you describe the circumstances that provoke the bug? Lots of
concurrent threads?<br>
Lots of concurrent work in progress?<br>
<br>
Jon<br>
<blockquote
cite="mid:CA+n_jhiSJqr5ec9rBM0p34wK+CX0WyYPwoEp+jd5wLSmA4i0sg@mail.gmail.com"
type="cite">
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Nov 4, 2015 at 9:25 AM, Jon
Masamitsu <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:jon.masamitsu@oracle.com" target="_blank">jon.masamitsu@oracle.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><span class=""> <br>
<br>
<div>On 11/3/2015 5:32 PM, Jungwoo Ha wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Somehow I didn't receive Jon's email.
<div>We've first noticed this on JDK8, but I think
the bug is more triggered with the tcmalloc +
custom launcher.</div>
<div><br>
</div>
</div>
</blockquote>
<br>
</span> Jungwoo,<br>
<br>
Do you have a test that exhibits the bug?<span
class="HOEnZb"><font color="#888888"><br>
<br>
Jon</font></span><span class=""><br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div><br>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, Nov 3, 2015 at 4:14
PM, Carsten Varming <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:varming@gmail.com"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:varming@gmail.com">varming@gmail.com</a></a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0
0 .8ex;border-left:1px #ccc
solid;padding-left:1ex">
<div dir="ltr">Dear Jon,
<div><br>
</div>
<div>I am pretty sure this has been that way
for a long time. I have never seen a
problem, but I would like to see Hotspot
shut down its threads as well.</div>
<div><br>
</div>
<div>Carsten</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, Nov 3, 2015
at 5:40 PM, Jon Masamitsu <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:jon.masamitsu@oracle.com"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:jon.masamitsu@oracle.com">jon.masamitsu@oracle.com</a></a>></span>
wrote:<br>
<blockquote class="gmail_quote"
style="margin:0 0 0 .8ex;border-left:1px
#ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> <font
face="Times New Roman, Times, serif">Jungwoo,<br>
<br>
Did you first see this bug in jdk8?
I'm wondering if it<br>
was always broken.<span><font
color="#888888"><br>
<br>
Jon<br>
</font></span></font>
<div>
<div>
<div>
<div><br>
<div>On 11/03/2015 01:14 PM,
Jungwoo Ha wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">BUG: <a
moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8141356"
target="_blank"><a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8141356">https://bugs.openjdk.java.net/browse/JDK-8141356</a></a>
<div>Webrev: <a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ejwha/8141356/webrev.00/"
target="_blank"><a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~jwha/8141356/webrev.00/">http://cr.openjdk.java.net/~jwha/8141356/webrev.00/</a></a></div>
<div><br>
</div>
<div>
<div>Inside before_exit(),
it says </div>
<div><br>
</div>
<div><font
face="monospace,
monospace"> // Stop
concurrent GC threads </font></div>
<div><font
face="monospace,
monospace">
Universe::heap()->stop(); </font></div>
<div><br>
</div>
<div>but GenCollectedHeap
never implemented stop()
method, and thus calling
empty SharedHeap::stop()
method. </div>
<div>This causes CMS
threads to run during
the VM termination and
ends up crashing. <br>
</div>
<div><span style="color:rgb(0,0,0);white-space:pre-wrap">ConcurrentMarkSweepThread::stop() is currently a dead code and never gets called.</span><br>
</div>
<div><span style="color:rgb(0,0,0);white-space:pre-wrap">The patch just implemented GenCollectedHeap::stop() to call </span><span style="color:rgb(0,0,0);white-space:pre-wrap">ConcurrentMarkSweepThread::stop().</span></div>
<div><br>
</div>
<div>Can someone sponsor
this patch?</div>
<div><br>
</div>
-- <br>
<div>
<div dir="ltr">
<div><span
style="font-size:12.8px">Jungwoo
Ha | Google | <a
moz-do-not-send="true" href="mailto:jwha@google.com" target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:jwha@google.com">jwha@google.com</a></a></span><br>
</div>
<div><br>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<br>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
<div>
<div dir="ltr">
<div><span style="font-size:12.8000001907349px">Jungwoo
Ha | Java Platform Team | <a
moz-do-not-send="true"
href="mailto:jwha@google.com"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:jwha@google.com">jwha@google.com</a></a></span><br>
</div>
<div><br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
</span></div>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
<div class="gmail_signature">
<div dir="ltr">
<div><span style="font-size:12.8000001907349px">Jungwoo Ha |
Java Platform Team | <a moz-do-not-send="true"
href="mailto:jwha@google.com" target="_blank">jwha@google.com</a></span><br>
</div>
<div><br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>