<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
Hi Kirk,<br>
<br>
<div class="moz-cite-prefix">On 2015-11-13 19:49, Kirk Pepperdine
wrote:<br>
</div>
<blockquote
cite="mid:6FC1952E-0C02-47B0-9D6F-036B41B64F37@gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
Hi Bengt,
<div class=""><br class="">
</div>
<div class="">GC(5) seems to be missing. from <a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ebrutisso/JEP-271/pre-review.02/logs/ConcMarkSweep-Xlog-gc-ergo-star-trace.txt"
class="">http://cr.openjdk.java.net/~brutisso/JEP-271/pre-review.02/logs/ConcMarkSweep-Xlog-gc-ergo-star-trace.txt</a></div>
</blockquote>
<br>
Good catch. This is a problem with the way CMS (or rather
GenCollectedHeap) can skip a young GC and directly kick off a full
collection if it finds that the young collection would fail. The way
GenCollectedHeap::do_collection() handles the two types of
collections that it can start is too complex in my opinion. <br>
<br>
This is the same code that makes this log:<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~brutisso/JEP-271/pre-review.02/logs/Serial-Xlog-gc-info.txt">http://cr.openjdk.java.net/~brutisso/JEP-271/pre-review.02/logs/Serial-Xlog-gc-info.txt</a><br>
<br>
look like collection number 5 and 3 come in the wrong order.<br>
<br>
(See the "Even more details..." section in my first pre-review:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~brutisso/JEP-271/pre-review.00/compare.html">http://cr.openjdk.java.net/~brutisso/JEP-271/pre-review.00/compare.html</a>)<br>
<br>
I will file an RFE to fix this but it is not really a logging
problem. It is more of a code structure problem. So, I would like to
fix this separately after the big unified logging change has been
pushed. The new logging just makes it more visible.<br>
<br>
Thanks,<br>
Bengt<br>
<br>
<br>
<blockquote
cite="mid:6FC1952E-0C02-47B0-9D6F-036B41B64F37@gmail.com"
type="cite">
<div class=""><br class="">
</div>
<div class="">Regards,</div>
<div class="">Kirk</div>
<div class=""><br class="">
<div>
<blockquote type="cite" class="">
<div class="">On Nov 13, 2015, at 9:56 AM, Bengt Rutisson
<<a moz-do-not-send="true"
href="mailto:bengt.rutisson@oracle.com" class="">bengt.rutisson@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class=""><br class="">
Hi everyone,<br class="">
<br class="">
Here is an updated pre-review for the work for JEP 271
Unified GC Logging.<br class="">
<br class="">
Now it includes all the logging that I plan on converting
for the first step.<br class="">
<br class="">
Here are examples from the latest prototype:<br class="">
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ebrutisso/JEP-271/pre-review.02/compare.html"
class="">http://cr.openjdk.java.net/~brutisso/JEP-271/pre-review.02/compare.html</a><br
class="">
<br class="">
The webrev for the changes is available here:<br class="">
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~brutisso/JEP-271/pre-review.02/webrev.02/">http://cr.openjdk.java.net/~brutisso/JEP-271/pre-review.02/webrev.02/</a><br
class="">
<br class="">
Some changes that have been made:<br class="">
<br class="">
- GC id is now logged as "GC(5)" instead of the previous
"GC#5"<br class="">
- The CMS and G1 concurrent logging have been homogenized
to look similar. All concurrent phases are start with
"Concurrent" and now include timestamps.<br class="">
- The paused phases now all start with "Pause".<br
class="">
- The log messages from the different collectors now look
more similar. For example "Pause Young" is used for young
GCs for all collectors instead of for example "Young
pause" for G1 and "Pause. ParNew" for CMS.<br class="">
- I've added a line at the start of the log to clearly
state what GC is selected.<br class="">
<br class="">
Thanks,<br class="">
Bengt<br class="">
<br class="">
</div>
</blockquote>
</div>
<br class="">
</div>
</blockquote>
<br>
</body>
</html>