<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<font face="Times New Roman, Times, serif">Kim,<br>
<br>
Looks good although I have one question. In<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~kbarrett/8143014/webrev.00/src/share/vm/gc/g1/satbMarkQueue.hpp.frames.html">http://cr.openjdk.java.net/~kbarrett/8143014/webrev.00/src/share/vm/gc/g1/satbMarkQueue.hpp.frames.html</a><br>
<br>
</font>
<pre><span class="new"> 76 using PtrQueue::byte_width_of_index;
</span></pre>
<pre><pre><span class="new"><a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~kbarrett/8143014/webrev.00/src/share/vm/gc/g1/dirtyCardQueue.hpp.frames.html">http://cr.openjdk.java.net/~kbarrett/8143014/webrev.00/src/share/vm/gc/g1/dirtyCardQueue.hpp.frames.html</a></span></pre><span class="new"></span></pre>
<br>
<pre><span class="new"> 80 using PtrQueue::byte_width_of_index;</span></pre>
<br>
Are the "using" statements actually needed? Or are they future
proofing?<br>
<br>
Jon<br>
<br>
<div class="moz-cite-prefix">On 11/15/2015 12:39 PM, Kim Barrett
wrote:<br>
</div>
<blockquote
cite="mid:902DBB5B-D1A9-4E92-9FD4-09AD8A3B4101@oracle.com"
type="cite">
<pre wrap="">Please review this cleanup of the API for accessing member offset
information for SATBMarkQueue and DirtyCardQueue. Clients now access
the specific queue class information. In addition, JVMCI now uses the
same API for obtaining the information as is used by other compilers
and interpreters.
Also moved the vmStruct declarations for PtrQueue and members to
vmStructs_g1.hpp, as that class is G1-specific.
CR:
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8143014">https://bugs.openjdk.java.net/browse/JDK-8143014</a>
Webrev:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~kbarrett/8143014/webrev.00/">http://cr.openjdk.java.net/~kbarrett/8143014/webrev.00/</a>
Testing:
JPRT
</pre>
</blockquote>
<br>
</body>
</html>