<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Erik,<br>
I'm getting out of my depth of knowledge of reference processing
here, so will put this in the form of a question. 8^) In addition
to what you describe below and in JBS, the new code explicitly
processes weak JNI handles if should_process_references() is false.
OK, that must be done regardless of whether processing normal ref
objects. (Perhaps a comment to this effect above the call to the
new process_weak_jni_handles would be good.)<br>
<br>
The code in ReferenceProcessor::process_discovered_references
contains some ancient comments about the ordering of processing
normal refs vs JNI refs, implying the latter must be last.
(Referring to the equally ancient <a class="issue-link"
data-issue-key="JDK-4126360"
href="https://bugs.openjdk.java.net/browse/JDK-4126360"
id="key-val" rel="4276142">JDK-4126360</a>. )<br>
<br>
This change seems to allow the order to be reversed, since JNI
handles will be processed before references are, at some point in
the future. Is there an issue that code might be relying on this
ordering?<br>
Tom<br>
<br>
<div class="moz-cite-prefix">On 11/12/2015 8:12 AM, Mikael Gerdin
wrote:<br>
</div>
<blockquote cite="mid:56449056.8030409@oracle.com" type="cite">Hi
Erik,
<br>
<br>
On 2015-11-10 14:05, Erik Helin wrote:
<br>
<blockquote type="cite">Hi all,
<br>
<br>
this patch adds the method `bool should_process_references()
const` to
<br>
G1CollectorPolicy and also updates G1CollectedHeap to make use
of it.
<br>
This enables a G1CollectorPolicy to make decisions about whether
<br>
references should be processed or not.
<br>
<br>
Enhancement:
<br>
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8139892">https://bugs.openjdk.java.net/browse/JDK-8139892</a>
<br>
<br>
Webrev:
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~ehelin/8139892/webrev.00/">http://cr.openjdk.java.net/~ehelin/8139892/webrev.00/</a>
<br>
</blockquote>
<br>
Looks good to me.
<br>
/Mikael
<br>
<br>
<blockquote type="cite">
<br>
Testing:
<br>
JPRT
<br>
<br>
Thanks,
<br>
Erik
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>