<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
Hi Ramki,<br>
<br>
Thanks for looking at this!<br>
<br>
<div class="moz-cite-prefix">On 2015-11-20 20:30, Srinivas
Ramakrishna wrote:<br>
</div>
<blockquote
cite="mid:CABzyjymfPLo9OfvA6VgDzSuqA2MH7xn4=tqXaMNXJ_GNVk1ncA@mail.gmail.com"
type="cite">
<div dir="ltr">Hi Bengt --
<div><br>
</div>
<div>This was code for debugging CMS. Should have been compiled
out of product build (i.e. protected with #ifndef PRODUCT).</div>
</div>
</blockquote>
<br>
Thanks for providing some background on this code!<br>
<br>
Yes, it kind of looked like debugging code to me, but it wasn't
clearly commented as such as it usually is. It was not protected
with #ifndef PRODUCT. <br>
<br>
<blockquote
cite="mid:CABzyjymfPLo9OfvA6VgDzSuqA2MH7xn4=tqXaMNXJ_GNVk1ncA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div><br>
</div>
<div>If it hasn't been used in a while for debugging CMS
crashes, then it's fine to remove it.</div>
<div>You might want to check with the sustaining folks to see
if they have had occasion to use it recently (like in</div>
<div>the past year or so), and if not then remove it.</div>
</div>
</div>
</blockquote>
<br>
I'll check with sustaining to see what they think.<br>
<br>
If we decide to keep the code I think we should switch from using
gclog_or_tty to using tty for printing. If you are in a debugger
(gdb or similar) you normally want the output on stdout and not to
some file that happened to be on the command line. :)<br>
<br>
<blockquote
cite="mid:CABzyjymfPLo9OfvA6VgDzSuqA2MH7xn4=tqXaMNXJ_GNVk1ncA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div><br>
</div>
<div>The code removal itself looks fine; reviewed.<br>
</div>
</div>
</div>
</blockquote>
<br>
Thanks,<br>
Bengt<br>
<br>
<blockquote
cite="mid:CABzyjymfPLo9OfvA6VgDzSuqA2MH7xn4=tqXaMNXJ_GNVk1ncA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div>
<div><br>
</div>
<div>-- ramki</div>
</div>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Fri, Nov 20, 2015 at 10:27 AM, Bengt
Rutisson <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:bengt.rutisson@oracle.com" target="_blank">bengt.rutisson@oracle.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><span
class=""><br>
<br>
On 2015-11-20 19:37, Thomas Schatzl wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
On Fri, 2015-11-20 at 17:37 +0100, Bengt Rutisson wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi everyone,<br>
<br>
Could I have a couple of reviews for this small
change?<br>
<br>
<a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8143544"
rel="noreferrer" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8143544</a><br>
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ebrutisso/8143544/webrev.00/"
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~brutisso/8143544/webrev.00/</a><br>
<br>
CMSCollector::is_cms_reachable() is dead code.<br>
<br>
</blockquote>
looks good.<br>
</blockquote>
<br>
</span>
Thanks, Thomas!<br>
<br>
Bengt<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Thomas<br>
<br>
<br>
</blockquote>
<br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>