<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
Hi Kirk,<br>
<br>
<div class="moz-cite-prefix">On 2015-11-23 14:26,
<a class="moz-txt-link-abbreviated" href="mailto:kirk.pepperdine@gmail.com">kirk.pepperdine@gmail.com</a> wrote:<br>
</div>
<blockquote
cite="mid:28122DD9-19D6-49AF-83A5-5D4C2A11D11B@gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div class="">Hi Bengt,</div>
<div class=""><br class="">
</div>
I’ve not seen anything egregious as of yet though I’m no where
near done.</blockquote>
<br>
Thanks for looking at this change!<br>
<br>
<blockquote
cite="mid:28122DD9-19D6-49AF-83A5-5D4C2A11D11B@gmail.com"
type="cite">One comment for ostream.cpp.
<div class=""><br class="">
</div>
<div class="">
<pre style="background-color: rgb(238, 238, 238);" class=""><span class="removed" style="color: rgb(165, 42, 42);">-// log_name comes from -XX:LogFile=log_name, -Xloggc:log_name or</span>
<span class="new" style="color: blue;">+// log_name comes from -XX:LogFile=log_name or</span>
// -XX:DumpLoadedClassList=<file_name></pre>
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
<div class="">IME, -Xloggc:log_name is the most common form
used. Not stuck to it, just saying…</div>
</div>
</blockquote>
<br>
Are you saying that it is scary to remove -Xloggc? Yes, I would
agree. We've discussed it a bit here. It would be nice to get rid of
it since it comes with a bunch of other issues such as log rotation
etc. One way to handle the transition would be to map
-Xloggc=filename to -Xlog:gc*:filename. It wouldn't be 100% correct
and it wouldn't handle the log rotations flags. But maybe it would
be a smoother transition for some users.<br>
<br>
Regards,<br>
Bengt<br>
<br>
<blockquote
cite="mid:28122DD9-19D6-49AF-83A5-5D4C2A11D11B@gmail.com"
type="cite">
<div class="">
<div class=""><br class="">
</div>
<div class="">Regards,</div>
<div class="">Kirk</div>
<div class=""><br class="">
</div>
<div>
<blockquote type="cite" class="">
<div class="">On Nov 23, 2015, at 9:43 AM, Bengt Rutisson
<<a moz-do-not-send="true"
href="mailto:bengt.rutisson@oracle.com" class="">bengt.rutisson@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class=""><br class="">
Hi Per,<br class="">
<br class="">
Thanks for looking at this!<br class="">
<br class="">
On 2015-11-23 09:51, Per Liden wrote:<br class="">
<blockquote type="cite" class="">Hi Bengt,<br class="">
<br class="">
On 2015-11-19 16:29, Bengt Rutisson wrote:<br class="">
<blockquote type="cite" class=""><br class="">
Hi everyone,<br class="">
<br class="">
After three pre-reviews it is time for the fist
official review request<br class="">
for JEP-271 Unified GC Logging.<br class="">
<br class="">
<a moz-do-not-send="true"
href="http://openjdk.java.net/jeps/271" class="">http://openjdk.java.net/jeps/271</a><br
class="">
<br class="">
Most code changes are in the hotspot code:<br
class="">
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~brutisso/JEP-271/review.00/webrev.00/">http://cr.openjdk.java.net/~brutisso/JEP-271/review.00/webrev.00/</a><br
class="">
</blockquote>
<br class="">
This is not a complete review, just a few things I
noticed while browsing the webrev.<br class="">
<br class="">
----------------------------------------------<br
class="">
/src/share/vm/gc/g1/g1StringDedupQueue.cpp<br class="">
<br class="">
157 log_trace(gc, stringdedup)(<br class="">
158 " [Queue]\n"<br class="">
159 " [Dropped: " UINTX_FORMAT "]",
_queue->_dropped);<br class="">
<br class="">
Multi-line loging.<br class="">
<br class="">
----------------------------------------------<br
class="">
src/share/vm/gc/g1/g1StringDedupTable.cpp<br class="">
<br class="">
573 log_trace(gc, stringdedup)(<br class="">
574 " [Table]\n"<br class="">
575 " [Memory Usage: "
G1_STRDEDUP_BYTES_FORMAT_NS "]\n"<br class="">
576 " [Size: " SIZE_FORMAT ", Min: "
SIZE_FORMAT ", Max: " SIZE_FORMAT "]\n"<br class="">
577 " [Entries: " UINTX_FORMAT ", Load: "
G1_STRDEDUP_PERCENT_FORMAT_NS ", Cached: "
UINTX_FORMAT ", Added: " UINTX_FORMAT ", Removed: "
UINTX_FORMAT "]\n"<br class="">
578 " [Resize Count: " UINTX_FORMAT ", Shrink
Threshold: " UINTX_FORMAT "("
G1_STRDEDUP_PERCENT_FORMAT_NS "), Grow Threshold: "
UINTX_FORMAT "(" G1_STRDEDUP_PERCENT_FORMAT_NS ")]\n"<br
class="">
579 " [Rehash Count: " UINTX_FORMAT ", Rehash
Threshold: " UINTX_FORMAT ", Hash Seed: 0x%x]\n"<br
class="">
580 " [Age Threshold: " UINTX_FORMAT "]",<br
class="">
<br class="">
Multi-line logging.<br class="">
<br class="">
----------------------------------------------<br
class="">
</blockquote>
<br class="">
Good catch. Will fix.<br class="">
<br class="">
<blockquote type="cite" class="">src/share/vm/gc/g1/g1StringDedup*.cpp<br
class="">
<br class="">
In general, I think the string dedup logging currently
done with log_trace() should be log_debug() instead.<br
class="">
</blockquote>
<br class="">
Yes, that makes sense. Will change that.<br class="">
<br class="">
Bengt<br class="">
<br class="">
<br class="">
<blockquote type="cite" class=""><br class="">
cheers,<br class="">
/Per<br class="">
<br class="">
<blockquote type="cite" class=""><br class="">
Some tests in the JDK repo have been updated:<br
class="">
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ebrutisso/JEP-271/review.00/jdk-webrev.00/"
class="">http://cr.openjdk.java.net/~brutisso/JEP-271/review.00/jdk-webrev.00/</a><br
class="">
<br class="">
As with the pre-reviews I have put togther some
examples of what the new<br class="">
logging looks like:<br class="">
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~brutisso/JEP-271/review.00/compare.html">http://cr.openjdk.java.net/~brutisso/JEP-271/review.00/compare.html</a><br
class="">
<br class="">
The intent is that this should cover the bulk of the
logging changes.<br class="">
There will most definitely be some follow up changes
where we fix<br class="">
details in the log messages etc.<br class="">
<br class="">
Among many other old logging flags this changeset
removes the two flags<br class="">
PringGC and PrintGCDetails. These two will be added
back with a follow<br class="">
up changeset, but when they are added back they will
be marked as<br class="">
deprecated.<br class="">
<br class="">
The reason for first removing them and then adding
them back is to get<br class="">
testing without these flags. That way we will know
that we clean out all<br class="">
usages of these flags from our testing.<br class="">
<br class="">
Thanks,<br class="">
Bengt<br class="">
</blockquote>
</blockquote>
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</blockquote>
<br>
</body>
</html>