<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
Hi Ramki and Thomas,<br>
<br>
<div class="moz-cite-prefix">On 2015-11-20 21:17, Srinivas
Ramakrishna wrote:<br>
</div>
<blockquote
cite="mid:CABzyjykX6jG_5e5-VEKQJx1Zn+9ViHJLLr8BQAk2dG-F5-p0Rw@mail.gmail.com"
type="cite">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Fri, Nov 20, 2015 at 11:27 AM,
Bengt Rutisson <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:bengt.rutisson@oracle.com" target="_blank">bengt.rutisson@oracle.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><span class=""><br>
</span><span class="">...<br>
</span> I'll check with sustaining to see what they
think.<br>
</div>
</blockquote>
<div><br>
</div>
<div>Cool.</div>
</div>
</div>
</div>
</blockquote>
<br>
I checked with sustaining. They have not been using this code for
quite some time but they would like to keep it.<br>
<br>
So, instead of removing it I have guarded it with #ifndef PRODUCT
and changed to use tty rather than gclog_or_tty. Here's an updated
webrev:<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~brutisso/8143544/webrev.01/">http://cr.openjdk.java.net/~brutisso/8143544/webrev.01/</a><br>
<br>
I've also updated the synopsis of the Jira issue to be "Make
CMSCollector::is_cms_reachable() non-product".<br>
<br>
Thanks,<br>
Bengt<br>
<blockquote
cite="mid:CABzyjykX6jG_5e5-VEKQJx1Zn+9ViHJLLr8BQAk2dG-F5-p0Rw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> <br>
If we decide to keep the code I think we should switch
from using gclog_or_tty to using tty for printing. If
you are in a debugger (gdb or similar) you normally want
the output on stdout and not to some file that happened
to be on the command line. :)</div>
</blockquote>
<div><br>
</div>
<div>Good point.</div>
<div><br>
</div>
<div>- ramki</div>
</div>
<br>
</div>
</div>
</blockquote>
<br>
</body>
</html>