<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<br>
<div class="moz-cite-prefix">On 11/25/2015 1:31 AM, David Lindholm
wrote:<br>
</div>
<blockquote cite="mid:5655800D.7040501@oracle.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
Jon,<br>
<br>
Sorry, I don't really understand. The filler objects are needed to
fix "8138681: Runtime.getFreeMemory() reports wrong value after
humongous allocation."<br>
</blockquote>
<br>
David,<br>
<br>
If you were going to set the top of the H-region to the end of the <br>
H-object in cases where there was not enough room for a filler<br>
object, I wondered why you do not do that all the time (skip<br>
the filler object). I see from 8138681 that such a strategy does<br>
not work because the free space is then over estimated.<br>
<br>
So answer to my question is "no".<br>
<br>
I've not looked at all the details of the fix yet. Don't wait<br>
for me if you get other reviews.<br>
<br>
Jon<br>
<br>
<blockquote cite="mid:5655800D.7040501@oracle.com" type="cite"> <br>
<br>
Thanks,<br>
David<br>
<br>
<div class="moz-cite-prefix">On 2015-11-24 19:54, Jon Masamitsu
wrote:<br>
</div>
<blockquote cite="mid:5654B24C.7000201@oracle.com" type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
<font face="Times New Roman, Times, serif">David,<br>
<br>
Could be always just set top as you've done for the case where
there<br>
isn't room for a filler object at the end of a humongous
region? And<br>
never use a filler object there?<br>
<br>
Jon<br>
<br>
</font>
<div class="moz-cite-prefix">On 11/24/2015 04:50 AM, David
Lindholm wrote:<br>
</div>
<blockquote cite="mid:56545D02.9070200@oracle.com" type="cite">Hi,
<br>
<br>
After offline discussions with Mikael I have updated the
webrev (and the title of the bug). <br>
<br>
Webrev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Edavid/JDK-8143587/webrev.01/">http://cr.openjdk.java.net/~david/JDK-8143587/webrev.01/</a>
<br>
<br>
<br>
Thanks, <br>
David <br>
<br>
On 2015-11-24 11:58, David Lindholm wrote: <br>
<blockquote type="cite">Hi, <br>
<br>
Please review the following patch that fixes the case where
we allocate a humongous object, and where the space left in
the humongous region cannot fit a filler object. In that
case we must set top of the last heap region to the end of
the object. Also, there is a new jtreg test which crashes
the JVM before this patch, and works fine after. <br>
<br>
Bug: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8143587">https://bugs.openjdk.java.net/browse/JDK-8143587</a>
<br>
Webrev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Edavid/JDK-8143587/webrev.00/">http://cr.openjdk.java.net/~david/JDK-8143587/webrev.00/</a>
<br>
<br>
Testing: Passed jprt including new test. <br>
<br>
<br>
Thanks, <br>
David <br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>