<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
Hi Kirk,<br>
<br>
<div class="moz-cite-prefix">On 2015-11-25 08:23,
<a class="moz-txt-link-abbreviated" href="mailto:kirk.pepperdine@gmail.com">kirk.pepperdine@gmail.com</a> wrote:<br>
</div>
<blockquote
cite="mid:470308D1-0F34-457B-A131-A8E1D70BAE9E@gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<br class="">
<div>
<blockquote type="cite" class="">
<div class="">On Nov 24, 2015, at 11:51 AM, Bengt Rutisson
<<a moz-do-not-send="true"
href="mailto:bengt.rutisson@oracle.com" class="">bengt.rutisson@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type" class="">
<div bgcolor="#FFFFFF" text="#000000" class=""> <br
class="">
Hi Kirk,<br class="">
<br class="">
<div class="moz-cite-prefix">On 2015-11-23 14:26, <a
moz-do-not-send="true"
class="moz-txt-link-abbreviated"
href="mailto:kirk.pepperdine@gmail.com">kirk.pepperdine@gmail.com</a>
wrote:<br class="">
</div>
<blockquote
cite="mid:28122DD9-19D6-49AF-83A5-5D4C2A11D11B@gmail.com"
type="cite" class="">
<meta http-equiv="Content-Type" content="text/html;
charset=utf-8" class="">
<div class="">Hi Bengt,</div>
<div class=""><br class="">
</div>
I’ve not seen anything egregious as of yet though I’m no
where near done.</blockquote>
<br class="">
Thanks for looking at this change!<br class="">
<br class="">
<blockquote
cite="mid:28122DD9-19D6-49AF-83A5-5D4C2A11D11B@gmail.com"
type="cite" class="">One comment for ostream.cpp.
<div class=""><br class="">
</div>
<div class="">
<pre style="background-color: rgb(238, 238, 238);" class=""><span class="removed" style="color: rgb(165, 42, 42);">-// log_name comes from -XX:LogFile=log_name, -Xloggc:log_name or</span>
<span class="new" style="color: blue;">+// log_name comes from -XX:LogFile=log_name or</span>
// -XX:DumpLoadedClassList=<file_name></pre>
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
<div class="">IME, -Xloggc:log_name is the most common
form used. Not stuck to it, just saying…</div>
</div>
</blockquote>
<br class="">
Are you saying that it is scary to remove -Xloggc? Yes, I
would agree. We've discussed it a bit here. It would be
nice to get rid of it since it comes with a bunch of other
issues such as log rotation etc. One way to handle the
transition would be to map -Xloggc=filename to
-Xlog:gc*:filename. It wouldn't be 100% correct and it
wouldn't handle the log rotations flags. But maybe it
would be a smoother transition for some users.<br class="">
</div>
</div>
</blockquote>
<div><br class="">
</div>
It’s a small change and a very sensible one. The only thing I’m
suggesting is that it’s worth considering this or any change in
light of the complexity/change tax that projects will have to
pay to move to 9. I see two arguments here, depreciate in 9,
remove in 10. Or, just pile it onto the tax. I guess you could
argue that since GC logging flags are already changing, the
later solution works best in both the short and long term.</div>
</blockquote>
<br>
Agreed. I'll look into adding some compatibility mapping for
-Xloggc. That and the compatibility mappings for PrintGC and
PringGCDetails will be pushed as a separate change after the main
change. This is to make sure that we clean out all usages of the old
flags from all tests and test harnesses that we have by really
removing the flags for a while.<br>
<br>
Regards,<br>
Bengt<br>
<br>
<blockquote
cite="mid:470308D1-0F34-457B-A131-A8E1D70BAE9E@gmail.com"
type="cite">
<div><br class="">
</div>
<div>Regards,</div>
<div>Kirk</div>
</blockquote>
<br>
</body>
</html>