<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
Thanks for reviewing this, Ramki!<br>
<br>
Bengt<br>
<br>
<div class="moz-cite-prefix">On 2015-11-24 20:49, Srinivas
Ramakrishna wrote:<br>
</div>
<blockquote
cite="mid:CABzyjy=fRbiSxz_Zef3osRRDSspPCZTN9b8QgwbrBSLjE97+ag@mail.gmail.com"
type="cite">
<div dir="ltr">Looks good to me too; thanks!
<div>-- ramki</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, Nov 24, 2015 at 12:46 AM, Bengt
Rutisson <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:bengt.rutisson@oracle.com" target="_blank">bengt.rutisson@oracle.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><span
class=""><br>
<br>
On 2015-11-24 09:51, Thomas Schatzl wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
On Tue, 2015-11-24 at 09:03 +0100, Bengt Rutisson wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Ramki and Thomas,<br>
<br>
</blockquote>
[...]<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
I checked with sustaining. They have not been using
this code for<br>
quite some time but they would like to keep it.<br>
<br>
So, instead of removing it I have guarded it with
#ifndef PRODUCT and<br>
changed to use tty rather than gclog_or_tty. Here's an
updated webrev:<br>
<br>
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ebrutisso/8143544/webrev.01/"
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~brutisso/8143544/webrev.01/</a><br>
<br>
I've also updated the synopsis of the Jira issue to be
"Make<br>
CMSCollector::is_cms_reachable() non-product".<br>
</blockquote>
<br>
looks good.<br>
</blockquote>
<br>
</span>
Thanks, Thomas!<br>
<br>
Bengt<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Thomas<br>
<br>
<br>
</blockquote>
<br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>