<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Thank you, Bengt!<br>
<br>
-- Dima<br>
<br>
<div class="moz-cite-prefix">On 26.11.2015 10:17, Bengt Rutisson
wrote:<br>
</div>
<blockquote cite="mid:5656B209.1060107@oracle.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<br>
Hi Dima,<br>
<br>
<div class="moz-cite-prefix">On 2015-11-16 18:46, Dmitry Fazunenko
wrote:<br>
</div>
<blockquote cite="mid:564A1693.5090205@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
Hello,<br>
<br>
may I have a couple of reviews for a fix made Andrey Zakharov,
please:<br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8016752">https://bugs.openjdk.java.net/browse/JDK-8016752</a><br>
<div class="moz-forward-container"><a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Edfazunen/8016752/webrev.00/">http://cr.openjdk.java.net/~dfazunen/8016752/webrev.00/</a><br>
</div>
</blockquote>
<br>
Looks ok.<br>
<br>
Thanks,<br>
Bengt<br>
<br>
<blockquote cite="mid:564A1693.5090205@oracle.com" type="cite">
<div class="moz-forward-container"> <br>
Comments: during the fix TEST.ROOT is modified: java.version
is registered as a property that can be used in the @requires
tag.<br>
It allows to declare a test as fastdebug specific:<br>
<br>
<pre>@requires java.version ~= ".*fastdebug"</pre>
<br>
Thanks,<br>
Dima<br>
<br>
<br>
<br>
<br>
<br>
-------- Forwarded Message --------
<table class="moz-email-headers-table" border="0"
cellpadding="0" cellspacing="0">
<tbody>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Subject:
</th>
<td>Re: [RFR] 8016752: Test case for 8005857/8016740
(assert in GC_locker from PSOldGen::expand with
-XX:+PrintGCDetails and Verbose)</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Date:
</th>
<td>Mon, 01 Jun 2015 14:28:14 +0300</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">From:
</th>
<td>Andrey Zakharov <a moz-do-not-send="true"
class="moz-txt-link-rfc2396E"
href="mailto:andrey.x.zakharov@oracle.com"><andrey.x.zakharov@oracle.com></a></td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">To:
</th>
<td>Dmitry Fazunenko <a moz-do-not-send="true"
class="moz-txt-link-rfc2396E"
href="mailto:dmitry.fazunenko@oracle.com"><dmitry.fazunenko@oracle.com></a></td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">CC:
</th>
<td>Thomas Schatzl <a moz-do-not-send="true"
class="moz-txt-link-rfc2396E"
href="mailto:thomas.schatzl@oracle.com"><thomas.schatzl@oracle.com></a>,
<a moz-do-not-send="true"
class="moz-txt-link-abbreviated"
href="mailto:hotspot-gc-dev@openjdk.java.net">hotspot-gc-dev@openjdk.java.net</a></td>
</tr>
</tbody>
</table>
<br>
<br>
<pre>It was resubmitted in February
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2015-February/012028.html">http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2015-February/012028.html</a>
I'll update patch and re-upload it.
Thanks.
On 27.05.2015 18:13, Dmitry Fazunenko wrote:
> Hi Andrey,
>
> jtreg does already support "~=" in @requires, could you resubmit the
> change please.
>
> Thanks,
> Dima
>
> On 12.11.2014 15:45, Dmitry Fazunenko wrote:
>> Hi Andrey,
>>
>> I think it's too early to rely on '~=' in @requires. There is no
>> guarantee that it will be supported. (I hope it will).
>>
>> You also need to add @requires and list GC the test will work with.
>>
>> Thanks,
>> Dima
>>
>>
>> On 12.11.2014 14:59, Andrey Zakharov wrote:
>>> Hi, team
>>> As this test requires fastdebug build, here is update according to
>>> latest changes to jtreg (@requires tag).
>>> Also I've suggested patch to jtreg for support matching against
>>> regexp patterns in @requires expressions (like "foo bar" ~= ".*bar")
>>> *(its blocker for original tesbug now)
>>>
>>> webrev:
>>> <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Eazakharov/8016752/webrev.02/">http://cr.openjdk.java.net/~azakharov/8016752/webrev.02/</a>
>>>
>>> testbug:
>>> <a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8016752">https://bugs.openjdk.java.net/browse/JDK-8016752</a>
>>>
>>> Thanks.
>>>
>>> On 10.11.2014 14:36, Andrey Zakharov wrote:
>>>> Hi, Thomas
>>>> Yes, its fails very stable on 7u40b31
>>>> # Internal Error
>>>> (/HUDSON/workspace/jdk7u40-2-build-linux-amd64-product/jdk7u40/hotspot/src/share/vm/memory/gcLocker.hpp:94),
>>>> pid=15099, tid=139928946063104
>>>> # assert(_needs_gc || SafepointSynchronize::is_at_safepoint())
>>>> failed: only read at safepoint
>>>>
>>>> with elapsed time (seconds): 1.273
>>>> on local linux x64 box.
>>>> And passed on b32.
>>>>
>>>> Also, there are batches in comments of bugs for builds before fix
>>>> and with fix.
>>>>
>>>>
>>>> On 04.11.2014 13:55, Thomas Schatzl wrote:
>>>>> Hi Andrey,
>>>>>
>>>>> On Wed, 2014-10-22 at 12:29 +0400, Andrey Zakharov wrote:
>>>>>> Hi, team.
>>>>>> Here is simple test for JVM don't crash when its with PSOldGen, low
>>>>>> memory and with -XX:+PrintGCDetails and -XX:+Verbose flags
>>>>>> (<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8016740">https://bugs.openjdk.java.net/browse/JDK-8016740</a>) based on Crasher
>>>>>> attached to original incident bug
>>>>>>
>>>>>> webrev:
>>>>>> <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Eazakharov/8016752/webrev/">http://cr.openjdk.java.net/~azakharov/8016752/webrev/</a>
>>>>> The test looks okay, but did you check that if you revert
>>>>> JDK-8016740,
>>>>> the test actually fails?
>>>>> The original reproducer was stressing the GC a lot more as it
>>>>> tried to
>>>>> cause crashes for 60 seconds.
>>>>>
>>>>> If that is the case, it looks okay to me.
>>>>>
>>>>> Thanks,
>>>>> Thomas
>>>>>
>>>>>
>>>>
>>>
>>
>
</pre>
<br>
</div>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>