<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi Joe,<br>
<br>
On 2015-12-09 19:30, Joseph Provino wrote:<br>
</div>
<blockquote cite="mid:56687329.8030506@oracle.com" type="cite">Please
review this very small change.
<br>
<br>
CR: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8139768">https://bugs.openjdk.java.net/browse/JDK-8139768</a>
<br>
<br>
Webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~jprovino/8139768/webrev.00">http://cr.openjdk.java.net/~jprovino/8139768/webrev.00</a>
<br>
</blockquote>
<br>
The rest of the file uses // for the comments. Could you change your
comment to be consistent with the rest of the file?<br>
<br>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<pre> // Lacking sufficient experience, CMSOldPLABResizeQuicker is disabled by
// default.
if (ResizeOldPLAB && CMSOldPLABResizeQuicker) {
- size_t multiple = _num_blocks[word_sz]/(CMSOldPLABToleranceFactor*CMSOldPLABNumRefills*n_blks);
+ /*
+ * On a 32-bit VM, the denominator can become zero before of integer overflow
+ * which is why there is cast to double.
+ */
+ size_t multiple = (size_t) (_num_blocks[word_sz]/((double)CMSOldPLABToleranceFactor*CMSOldPLABNumRefills*n_blks));</pre>
<br>
Thanks,<br>
StefanK<br>
<blockquote cite="mid:56687329.8030506@oracle.com" type="cite">
<br>
thanks.
<br>
<br>
joe
<br>
</blockquote>
<br>
</body>
</html>