<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div><span></span></div><div>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
Hi Mikael,<br>
<br>
Thank you for reviewing this.<br>
<br>
<div class="moz-cite-prefix">On 12/22/2015 01:31 AM, Mikael Gerdin
wrote:<br>
</div>
<blockquote cite="mid:56791877.6040605@oracle.com" type="cite">Hi
Sangheon,
<br>
<br>
On 12/22/2015 01:40 AM, sangheon wrote:
<br>
<blockquote type="cite">Hi Jesper,
<br>
<br>
Thank you for the review.
<br>
<br>
Sangheon
<br>
<br>
<br>
On 12/21/2015 04:39 PM, Jesper Wilhelmsson wrote:
<br>
<blockquote type="cite">Looks good!
<br>
/Jesper
<br>
<br>
Den 21/12/15 kl. 21:24, skrev sangheon:
<br>
<blockquote type="cite">Hi Jesper,
<br>
<br>
Thank you for looking at this.
<br>
<br>
On 12/21/2015 06:35 AM, Jesper Wilhelmsson wrote:
<br>
<blockquote type="cite">Hi Sangheon,
<br>
<br>
Did you consider a simpler approach with only nested ifs
instead of the
<br>
do-while with breaks? At least to me, that would be easier
to read.
<br>
</blockquote>
You are right.
<br>
<br>
Here's updated webrev.
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~sangheki/8144527/webrev.01">http://cr.openjdk.java.net/~sangheki/8144527/webrev.01</a>
<br>
</blockquote>
</blockquote>
</blockquote>
<br>
Would you mind moving the code for NewSizeThreadIncrease to a
method?
<br>
Something like "DefNewGeneration::adjust_for_thread_increase()"
<br>
<br>
Otherwise it looks good.
<br>
(I'll be on vacation after today so I don't need to see a new
webrev for the update)
<br>
</blockquote>
Okay.<br>
<br>
To make sure, I'm posting next webrev which includes Mikael's
comment.<br>
<br>
Webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~sangheki/8144527/webrev.02">http://cr.openjdk.java.net/~sangheki/8144527/webrev.02</a><br>
Testing: JPRT<br>
<br>
Thanks,<br>
Sangheon<br>
<br>
<br>
<blockquote cite="mid:56791877.6040605@oracle.com" type="cite">/Mikael
<br>
<br>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<br>
Thanks,
<br>
Sangheon
<br>
<br>
<br>
<blockquote type="cite">
<br>
Besides that it looks good.
<br>
/Jesper
<br>
<br>
<br>
Den 21/12/15 kl. 07:52, skrev sangheon:
<br>
<blockquote type="cite">Hi all,
<br>
<br>
Can I have reviews for this change to prevent an
overflow for
<br>
NewSizeThreadIncrease?
<br>
<br>
This option is used with non-daemon threads count when
calculate
<br>
new size. And
<br>
as we can't know the thread count at start-up time, this
overflow
<br>
can't be
<br>
checked by argument validation framework. Instead I
changed related
<br>
routines to
<br>
prevent the overflow and when it happens desired new
size will be
<br>
previous size.
<br>
This will affect only for Serial GC.
<br>
<br>
I added simple test to have 5 threads and then check the
log
<br>
whether we had heap
<br>
expansion or not.
<br>
<br>
CR: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8144527">https://bugs.openjdk.java.net/browse/JDK-8144527</a>
<br>
Webrev:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~sangheki/8144527/webrev.00">http://cr.openjdk.java.net/~sangheki/8144527/webrev.00</a>
<br>
Testing: JPRT
<br>
<br>
Thanks,
<br>
Sangheon
<br>
<br>
<br>
</blockquote>
</blockquote>
<br>
</blockquote>
</blockquote>
<br>
</blockquote>
</blockquote>
<br>
</div></body></html>