<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Hi <o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">This change finishes the cleanup started in "8146401: Clean up oop.hpp: add inline directives and fix header files"<o:p></o:p></p>
<p class="MsoNormal">by fixing the issues in gc files. See also <a href="https://bugs.openjdk.java.net/browse/JDK-8146395">
https://bugs.openjdk.java.net/browse/JDK-8146395</a> and the discussion <o:p></o:p></p>
<p class="MsoNormal">of this change in the rt mailing list: <a href="http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-January/017440.html">
http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-January/017440.html</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Most issues can be fixed by including the proper .inline.hpp header or moving a function there.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I added new files src/share/vm/gc/shared/referenceProcessor.inline.hpp and g1SATBCardTableModRefBS.inline.hpp.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I moved the following methods to their .cpp files. In case someone considers these<o:p></o:p></p>
<p class="MsoNormal">performance relevant, I will add an inline.hpp file for them:<o:p></o:p></p>
<p class="MsoNormal"> PromotedObject::next and ::setNext --> promotionInfo.cpp<o:p></o:p></p>
<p class="MsoNormal"> ObjectStartArray::object_start --> objectStartArray.cpp<o:p></o:p></p>
<p class="MsoNormal"> FillClosure::do_addr to --> psParallelCompact.cpp (ok, only used here)<o:p></o:p></p>
<p class="MsoNormal"> ageTable::add --> ageTable.cpp<o:p></o:p></p>
<p class="MsoNormal"> KlassSizeStats::count_array / ::count --> heapInspection.cpp<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Please review this change. I please need a sponsor. <o:p></o:p></p>
<p class="MsoNormal"><a href="http://cr.openjdk.java.net/~goetz/wr16/8146395-oopInline-gc/webrev.01/">http://cr.openjdk.java.net/~goetz/wr16/8146395-oopInline-gc/webrev.01/</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Best regards,<o:p></o:p></p>
<p class="MsoNormal"> Goetz Lindenmaier<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">(The webrev messed up some change comments, the diffs and patch are fine, though.)<o:p></o:p></p>
</div>
</body>
</html>