<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
Hi Erik,<br>
<br>
<div class="moz-cite-prefix">On 2016-01-13 17:18, Erik Helin wrote:<br>
</div>
<blockquote cite="mid:20160113161836.GI17653@ehelin.jrpg.bea.com"
type="cite">
<pre wrap="">On 2016-01-13, Stefan Johansson wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi Erik,
Thanks for doing this improvement.
On 2016-01-13 15:24, Erik Helin wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi all,
this patchs updates CollectorPolicy to use log_warning(gc, ergo) instead of
warning (as part of updating the GC code to use unified logging).
Enhancement:
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8146990">https://bugs.openjdk.java.net/browse/JDK-8146990</a>
Webrev:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~ehelin/8146990/00/webrev/">http://cr.openjdk.java.net/~ehelin/8146990/00/webrev/</a>
</pre>
</blockquote>
<pre wrap="">src/share/vm/gc/shared/collectorPolicy.cpp:
700 log_warning(gc, ergo)("GenCollectorPolicy::mem_allocate_work
retries %d times \n\t"
701 " size=" SIZE_FORMAT " %s", try_count,
size, is_tlab ? "(TLAB)" : "");
873 log_warning(gc, ergo)("satisfy_failed_metadata_allocation()
retries %d times \n\t"
874 " size=" SIZE_FORMAT, loop_count,
word_size);
After UL we avoid having multi-line logging statements. So I suggest you
either re-format these to only use a single line each.
</pre>
</blockquote>
<pre wrap="">
Nice catch, I missed the \t and the \n characters. New patches are
available at:
- full: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~ehelin/8146990/01/">http://cr.openjdk.java.net/~ehelin/8146990/01/</a>
- inc: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~ehelin/8146990/01/inc/">http://cr.openjdk.java.net/~ehelin/8146990/01/inc/</a></pre>
</blockquote>
<br>
Do you really want to change the output format of this line? You
changed from<br>
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
<br>
873 warning("satisfy_failed_metadata_allocation() retries %d
times \n\t"<br>
874 " size=" SIZE_FORMAT, loop_count, word_size);<br>
<br>
to<br>
<br>
873 log_warning(gc,
ergo)("satisfy_failed_metadata_allocation() retries %d times,"<br>
874 " size=" SIZE_FORMAT, loop_count,
word_size);<br>
<br>
That will change from a two line message to a single line. A more
correct translation if you just want to move from the old logging to
the new would be:<br>
<br>
873 log_warning(gc,
ergo)("satisfy_failed_metadata_allocation() retries %d times,",
loop_count);<br>
874 log_warning(gc, ergo)("\t size=" SIZE_FORMAT, word_size);<br>
<br>
I'm fine with changing to one line. Just asking if this is
intentional.<br>
<br>
Bengt<br>
<br>
<blockquote cite="mid:20160113161836.GI17653@ehelin.jrpg.bea.com"
type="cite">
<pre wrap="">
Thanks,
Erik
</pre>
<blockquote type="cite">
<pre wrap="">---
Otherwise the change looks good.
Thanks,
Stefan
</pre>
<blockquote type="cite">
<pre wrap="">Testing:
- JPRT
Thanks,
Erik
</pre>
</blockquote>
<pre wrap="">
</pre>
</blockquote>
</blockquote>
<br>
</body>
</html>