<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="DE" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D;mso-fareast-language:EN-US">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D;mso-fareast-language:EN-US">I please need a second reviewer for this change, as well as a sponsor.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D;mso-fareast-language:EN-US">The current webrev incorporating Stefan’s comments and a fix to g1OopClosures.hpp<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D;mso-fareast-language:EN-US">is this:
<a href="http://cr.openjdk.java.net/~goetz/wr16/8146395-oopInline-gc/webrev.02/">
http://cr.openjdk.java.net/~goetz/wr16/8146395-oopInline-gc/webrev.02/</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D;mso-fareast-language:EN-US">Best regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D;mso-fareast-language:EN-US"> Goetz.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> hotspot-gc-dev [mailto:hotspot-gc-dev-bounces@openjdk.java.net]
<b>On Behalf Of </b>Lindenmaier, Goetz<br>
<b>Sent:</b> Mittwoch, 13. Januar 2016 23:54<br>
<b>To:</b> hotspot-gc-dev@openjdk.java.net<br>
<b>Subject:</b> RFR(L): 8146395: Add inline qualifier in oop.hpp and fix inlining in gc files<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">Hi <o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">This change finishes the cleanup started in "8146401: Clean up oop.hpp: add inline directives and fix header files"<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">by fixing the issues in gc files. See also
<a href="https://bugs.openjdk.java.net/browse/JDK-8146395">https://bugs.openjdk.java.net/browse/JDK-8146395</a> and the discussion
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">of this change in the rt mailing list: <a href="http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-January/017440.html">
http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-January/017440.html</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Most issues can be fixed by including the proper .inline.hpp header or moving a function there.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">I added new files src/share/vm/gc/shared/referenceProcessor.inline.hpp and g1SATBCardTableModRefBS.inline.hpp.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">I moved the following methods to their .cpp files. In case someone considers these<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">performance relevant, I will add an inline.hpp file for them:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> PromotedObject::next and ::setNext --> promotionInfo.cpp<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> ObjectStartArray::object_start --> objectStartArray.cpp<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> FillClosure::do_addr to --> psParallelCompact.cpp (ok, only used here)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> ageTable::add --> ageTable.cpp<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> KlassSizeStats::count_array / ::count --> heapInspection.cpp<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Please review this change. I please need a sponsor.
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><a href="http://cr.openjdk.java.net/~goetz/wr16/8146395-oopInline-gc/webrev.01/">http://cr.openjdk.java.net/~goetz/wr16/8146395-oopInline-gc/webrev.01/</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Best regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"> Goetz Lindenmaier<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">(The webrev messed up some change comments, the diffs and patch are fine, though.)<o:p></o:p></span></p>
</div>
</div>
</body>
</html>