<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello Jon,<br>
<br>
<div class="moz-cite-prefix">On 1/28/2016 11:48 AM, Jon Masamitsu
wrote:<br>
</div>
<blockquote cite="mid:56AA7092.5010100@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<font face="Times New Roman, Times, serif">Poonam,<br>
<br>
Changes look good.<br>
</font></blockquote>
<br>
<font face="Times New Roman, Times, serif">Thanks for the review.</font><br>
<br>
<blockquote cite="mid:56AA7092.5010100@oracle.com" type="cite"><font
face="Times New Roman, Times, serif"> <br>
With VerifyBeforeGC and VerifyAfterGC the gc logs will look<br>
a little different? The rem-set verify part of the log will be
separate?<br>
Instead of <br>
<br>
2.701: [Full GC (Allocation Failure) VerifyBeforeGC:[Verifying
threads heap Roots HeapRegionSets HeapRegions RemSet syms strs
zone dict cldg metaspace chunks hand C-heap code cache ]<br>
<br>
the rem-set message will be from<br>
</font><br>
<pre><span class="new">4028 if (VerifyRememberedSets) {</span>
<span class="new">4029 if (PrintGCDetails) {</span>
<span class="new">4030 gclog_or_tty->print_cr("[Verifying RemSets before GC]");</span>
<span class="new">4031 }
</span></pre>
</blockquote>
<br>
Yes, the output with VerifyRememberedSets will be different from the
output with VerifyBeforeGC and VerifyAfterGC flags. Since
VerifyRememberedSets is not dependent on VerifyBeforeGC and
VerifyAfterGC options, it will be used independently when we don't
want to verify everything.<br>
<br>
Thanks,<br>
Poonam<br>
<br>
<blockquote cite="mid:56AA7092.5010100@oracle.com" type="cite">
<pre><span class="new">
Jon
</span></pre>
<br>
<br>
<div class="moz-cite-prefix">On 01/27/2016 12:03 PM, Poonam Bajaj
Parhar wrote:<br>
</div>
<blockquote cite="mid:56A922AF.4090100@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
Hello,<br>
<br>
Could I get reviews for the backport of the fix for <a
moz-do-not-send="true" class="issue-link"
data-issue-key="JDK-8145442"
href="https://bugs.openjdk.java.net/browse/JDK-8145442"
id="key-val" rel="4858280">JDK-8145442</a> to jdk8u.<br>
<br>
Webrev: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Epoonam/8145442/webrev.8u/">http://cr.openjdk.java.net/~poonam/8145442/webrev.8u/</a><br>
jdk9 changeset: <a moz-do-not-send="true"
href="http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/3666a5638df2">http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/3666a5638df2</a><br>
Testing: JPRT, GCBasher<br>
<br>
Thanks,<br>
Poonam<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>