<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<font face="Times New Roman, Times, serif">Changes look good. Reviewed.<br>
<br>
Jon<br>
</font><br>
<div class="moz-cite-prefix">On 02/01/2016 08:08 AM, Bengt Rutisson
wrote:<br>
</div>
<blockquote cite="mid:56AF82F2.7040004@oracle.com" type="cite">
<br>
Hi everyone,
<br>
<br>
Could I have a couple of reviews for this fix to enable some
metaspace logging in product mode?
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~brutisso/8147913/webrev.00/">http://cr.openjdk.java.net/~brutisso/8147913/webrev.00/</a>
<br>
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8147913">https://bugs.openjdk.java.net/browse/JDK-8147913</a>
<br>
<br>
Before the GC changes for unified logging, this logging used to be
guarded by:
<br>
<br>
if (PrintCompressedOopsMode || (PrintMiscellaneous &&
Verbose))
<br>
<br>
Verbose was always false in product builds but
PrintCompressedOopsMode was a diagnostic flag and thus the logging
was available in product builds.
<br>
<br>
The proposed change makes the log output available in product
builds on trace level.
<br>
<br>
Thanks,
<br>
Bengt
<br>
</blockquote>
<br>
</body>
</html>