<html><head><style>body{font-family:Helvetica,Arial;font-size:13px}</style></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">Thanks Thomas, I’ll fix those and post a new webrev shortly...</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">Tony</div> <br><p class="airmail_on">On February 8, 2016 at 10:56:56 AM, Thomas Schatzl (<a href="mailto:thomas.schatzl@oracle.com">thomas.schatzl@oracle.com</a>) wrote:</p> <blockquote type="cite" class="clean_bq"><span><div><div></div><div>Hi,
<br>
<br>On Mon, 2016-02-08 at 09:49 -0500, Tony Printezis wrote:
<br>> Thanks Thomas. Also, if you could do a JPRT run I’d very much
<br>> appreciate it.
<br>
<br>that is of course part of it.
<br>
<br>It found two issues:
<br> - RemoveForwardedPointerClosure::do_object() needs to be moved to the
<br>preservedMarks.inline.hpp as it uses oopDesc::is_forwarded() and
<br>init(). Then also oop.inline.hpp needs to be included there.
<br>
<br> - PreservedMarksSet::reclaim() needs to call
<br>~Padded<Preservedmarks>(), not just ~PreservedMarks.
<br>
<br>>
<br>> FWIW, I tested it with doing many runs of all the usual test suites
<br>> with -XX:+PromotionFailureALot -XX:PromotionFailureALotCount=150
<br>> -XX:PromotionFailureALotInterval=2 and this cause a bunch of
<br>> promotion failures. I didn’t see any issues.
<br>>
<br>> I also have the ParallelScavenge changes done (using the abstractions
<br>> introduced here). I’ll open those for code review when this is done.
<br>
<br>Thanks,
<br> Thomas
<br>
<br>
<br></div></div></span></blockquote> <div id="bloop_sign_1454961363153591040" class="bloop_sign"><div style="font-family:helvetica,arial;font-size:13px"><div>-----</div><div><br></div><div>Tony Printezis | JVM/GC Engineer / VM Team | Twitter</div><div><br></div><div>@TonyPrintezis</div><div><a href="mailto:tprintezis@twitter.com">tprintezis@twitter.com</a></div><div><br></div></div></div></body></html>