<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<font face="Times New Roman, Times, serif">Kim,<br>
<br>
Change looks good.<br>
<br>
Is it correct that the deactivation threshold could be overshot<br>
in the current implementation because the green zone can be less<br>
than the deactivation threshold? I don't have any reason to think<br>
that will cause a problem.<br>
<br>
I know that the logging messages are as in the original but<br>
I'd find</font><br>
<pre><span class="changed">Deactivated %d, <font color="#ff0000">at</font> threshold:</span></pre>
better than<br>
<pre><span class="changed">Deactivated %d, <font color="#ff0000">off</font> threshold:</span></pre>
at line 154 in the new version.<br>
<br>
Jon<br>
<pre><span class="changed">
</span></pre>
<br>
<br>
<div class="moz-cite-prefix">On 02/18/2016 12:20 PM, Kim Barrett
wrote:<br>
</div>
<blockquote
cite="mid:6149FB59-35A6-49AF-AEE3-33ACEFE336F0@oracle.com"
type="cite">
<pre wrap="">Please review this simplification of the deactivation of concurrent
refinement threads.
I also took the opportunity to move the activate/deactivate logging
messages for those threads. One benefit of this is that the primary
thread (worker_id 0) now generates such log messages. Note that just
moving the logging within the activate/deactivate functions wouldn't
have fixed that, since the primary thread is not currently activated
via a call to the activate function. That's an oddity that I plan to
fix later.
One side effect of the logging change: it is now apparent that the
primary refinement thread gets activated during a pause, though
fortunately immediately blocks on the SuspendibleThreadSetJoiner.
That's another problem that I plan to fix later.
CR:
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8150134">https://bugs.openjdk.java.net/browse/JDK-8150134</a>
Webrev:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~kbarrett/8150134/webrev.00/">http://cr.openjdk.java.net/~kbarrett/8150134/webrev.00/</a>
Testing:
JPRT
</pre>
</blockquote>
<br>
</body>
</html>