<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 3/10/16 4:59 AM, Bengt Rutisson
wrote:<br>
</div>
<blockquote cite="mid:56E14599.3080509@oracle.com" type="cite">
<br>
Hi everyone,
<br>
<br>
Could I have a couple of reviews for this change?
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~brutisso/8151604/webrev.00/">http://cr.openjdk.java.net/~brutisso/8151604/webrev.00/</a>
<br>
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8151604">https://bugs.openjdk.java.net/browse/JDK-8151604</a>
<br>
<br>
With the new range checking in the argument parsing we don't need
to have explicit checks in the code to handle invalid arguments.
<br>
<br>
Thanks,
<br>
Bengt
<br>
</blockquote>
<br>
Great idea. Only comment is that this can go further (I only checked
g1CollectorPolicy):<br>
<br>
g1CollectorPolicy.cpp:<br>
- Line 186, can change tests of MaxGCPauseMillis to guarantee(),
because:<br>
range(1, max_uintx)<br>
- Line 192, can change tests of GCPauseIntervalMillis to
guarantee(), because:<br>
OK, this doesn't have a range defined, but it should:
range(1, max_uintx)<br>
<br>
The checks from lines 220-228 are probably covered by the constraint
functions (MaxGCPauseMillisConstraintFunc(), etc), but this RFE is
about ranges :-)<br>
<br>
- Line 293, can change tests of SurvivorRatio to guarantee(),
because:<br>
range(1, max_uintx-2)<br>
<br>
- Derek<br>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
</body>
</html>