<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi Bengt,<br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ebrutisso/8151604/webrev.01/">webrev.01</a>
looks good!<br>
<br>
- Derek<br>
<br>
On 3/11/16 7:38 AM, Bengt Rutisson wrote:<br>
</div>
<blockquote cite="mid:56E2BC5D.3000000@oracle.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<br>
Hi Derek,<br>
<br>
Thanks for looking at this!<br>
<br>
<div class="moz-cite-prefix">On 2016-03-10 17:03, Derek White
wrote:<br>
</div>
<blockquote cite="mid:56E19ADD.5040702@oracle.com" type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 3/10/16 4:59 AM, Bengt Rutisson
wrote:<br>
</div>
<blockquote cite="mid:56E14599.3080509@oracle.com" type="cite">
<br>
Hi everyone, <br>
<br>
Could I have a couple of reviews for this change? <br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ebrutisso/8151604/webrev.00/">http://cr.openjdk.java.net/~brutisso/8151604/webrev.00/</a>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8151604">https://bugs.openjdk.java.net/browse/JDK-8151604</a>
<br>
<br>
With the new range checking in the argument parsing we don't
need to have explicit checks in the code to handle invalid
arguments. <br>
<br>
Thanks, <br>
Bengt <br>
</blockquote>
<br>
Great idea. Only comment is that this can go further (I only
checked g1CollectorPolicy):<br>
<br>
g1CollectorPolicy.cpp:<br>
- Line 186, can change tests of MaxGCPauseMillis to guarantee(),
because:<br>
range(1, max_uintx)<br>
</blockquote>
<br>
Fixed.<br>
<br>
<blockquote cite="mid:56E19ADD.5040702@oracle.com" type="cite"> -
Line 192, can change tests of GCPauseIntervalMillis to
guarantee(), because:<br>
OK, this doesn't have a range defined, but it should:
range(1, max_uintx)<br>
</blockquote>
<br>
This code only checks that it is >= 1, which is exactly what
GCPauseIntervalMillisConstraintFunc does. So, I changed this to a
guarantee as well.<br>
<br>
<blockquote cite="mid:56E19ADD.5040702@oracle.com" type="cite"> <br>
The checks from lines 220-228 are probably covered by the
constraint functions (MaxGCPauseMillisConstraintFunc(), etc),
but this RFE is about ranges :-)<br>
</blockquote>
<br>
I changed those as well, even if they are constraint based rather
than ranges. <br>
<br>
<blockquote cite="mid:56E19ADD.5040702@oracle.com" type="cite"> <br>
- Line 293, can change tests of SurvivorRatio to guarantee(),
because:<br>
range(1, max_uintx-2)<br>
</blockquote>
<br>
Fixed.<br>
<br>
There may be more of those that we can fix, but I think this is a
good start. I mostly wanted to get rid of the warning() calls.<br>
<br>
Updated webrev:<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ebrutisso/8151604/webrev.01/">http://cr.openjdk.java.net/~brutisso/8151604/webrev.01/</a><br>
<br>
Diff compared to last version:<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ebrutisso/8151604/webrev.00-01.diff/">http://cr.openjdk.java.net/~brutisso/8151604/webrev.00-01.diff/</a><br>
<br>
Thanks,<br>
Bengt<br>
<br>
<blockquote cite="mid:56E19ADD.5040702@oracle.com" type="cite"> <br>
- Derek<br>
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>