<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<font face="Times New Roman, Times, serif">Bengt,<br>
<br>
Thanks for the review.<br>
</font><br>
<div class="moz-cite-prefix">On 03/21/2016 02:13 AM, Bengt Rutisson
wrote:<br>
</div>
<blockquote cite="mid:56EFBB50.8060801@oracle.com" type="cite">
<br>
Hi Jon,
<br>
<br>
On 2016-03-21 03:43, Jon Masamitsu wrote:
<br>
<blockquote type="cite">The averages reported for phase times (for
example "Ext Root Scanning") were
<br>
incorrect. Not all the per thread values were included in the
sum and the
<br>
average value was incorrect (this with build 9-ea+1100)
<br>
<br>
[0.366s][debug][gc,phases ] GC(2) Ext Root
Scanning (ms): Min: 0.3, Avg: 0.2, Max: 0.4, Diff: 0.0,
Sum: 0.3
<br>
[0.366s][trace][gc,phases,task ]
GC(2) 0.4 0.3
<br>
<br>
With the fix all values are included in the sum and the average
is correct.
<br>
<br>
[2.830s][debug][gc,phases ] GC(0) Ext Root
Scanning (ms): Min: 5.7, Avg: 7.3, Max: 8.9, Diff: 3.1,
Sum: 14.6
<br>
[2.830s][trace][gc,phases,task ]
GC(0) 8.9 5.7
<br>
<br>
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8152208">https://bugs.openjdk.java.net/browse/JDK-8152208</a>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~jmasa/8152208/webrev.00/">http://cr.openjdk.java.net/~jmasa/8152208/webrev.00/</a>
<br>
</blockquote>
<br>
Nice catch! Your change looks good.
<br>
<br>
The method WorkerDataArray<T>::sum(uint active_threads) just
above the average() method has the same issue. Can you fix that
too?
<br>
</blockquote>
<br>
Yes, indeed.<br>
<br>
I messed up the delta a bit so all the changes are in the
workerDataArray.inline.hpp<br>
webrev. The test has not changed.<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~jmasa/8152208/webrev.01/">http://cr.openjdk.java.net/~jmasa/8152208/webrev.01/</a><br>
<br>
Jon<br>
<br>
<blockquote cite="mid:56EFBB50.8060801@oracle.com" type="cite">
<br>
Thanks,
<br>
Bengt
<br>
<br>
<blockquote type="cite">
<br>
Thanks.
<br>
<br>
Jon
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>