<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi Tom,<br>
<br>
On 3/19/16 9:10 AM, Tom Benson wrote:<br>
</div>
<blockquote cite="mid:56ED4FCB.9000807@oracle.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
Hi Derek,<br>
Thanks for taking a look. I see that the link under the webrev
text was bad due to cut/paste, so here's a good one for any new
readers:<br>
Webrev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Etbenson/8142935/webrev/">http://cr.openjdk.java.net/~tbenson/8142935/webrev/</a><br>
<br>
<div class="moz-cite-prefix">On 3/18/2016 6:22 PM, Derek White
wrote:<br>
</div>
<blockquote cite="mid:56EC7FA5.8040706@oracle.com" type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
<div class="moz-cite-prefix"><br>
</div>
My main question is that it looks like the accounting:<br>
<blockquote>_inc_bytes_used_before<br>
_inc_bytes_live_before<br>
_bytes_used_before<br>
_bytes_lived_before<br>
</blockquote>
are a summary of the bytes used and live in the young regions.<br>
<br>
In the new test in
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
G1CollectionSet::finalize_old_part(), I don't see that it's
accounting for the live bytes of the old regions it already
added to the cset. For example if the young regions had no live
data, then we might still add too many old regions to the cset?<br>
</blockquote>
<br>
The update to _bytes_live_before at line 100 of
g1CollectionSet.cpp is inside add_old_region(), so I think that
should account for them. Thanks,<br>
</blockquote>
<br>
OK, I see it. I agree with Kim's comment to, otherwise looks great.<br>
<br>
- Derek<br>
<blockquote cite="mid:56ED4FCB.9000807@oracle.com" type="cite"> Tom<br>
<br>
<br>
<blockquote cite="mid:56EC7FA5.8040706@oracle.com" type="cite"> <br>
The rest of it looks good.<br>
<br>
- Derek<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>