<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div><blockquote type="cite" class=""><div class="">On 22 Mar 2016, at 21:05, Thomas Schatzl <<a href="mailto:thomas.schatzl@oracle.com" class="">thomas.schatzl@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Hi all,<br class=""><br class=""> can I have reviews for the following one-liner?<br class=""><br class="">If you enable TASK_QUEUE_STATS for a product build for analysis, you<br class="">can't immediately use them. You also need to change another line of<br class="">code from log_develop_is_enabled() to log_is_enabled().<br class=""><br class="">This seems strange: if I want the task queue stats, I surely intend to<br class="">use it, and since that latter condition only filters out the printing<br class="">itself, the overhead has already been incurred anyway.<br class=""><br class="">This change changes the log_develop_is_enabled() check to<br class="">log_is_enabled() to avoid an additional round of changes after noticing<br class="">that task queue stats are not printed.<br class=""><br class="">There is no difference in performance for product builds, as the whole<br class="">code is compiled out, in non-product builds there is an extra trivial<br class="">condition to be checked per gc. I do not think this is noticeable at<br class="">all.<br class=""><br class="">CR:<br class=""><a href="https://bugs.openjdk.java.net/browse/JDK-8152400" class="">https://bugs.openjdk.java.net/browse/JDK-8152400</a><br class="">Webrev:<br class=""><a href="http://cr.openjdk.java.net/~tschatzl/8152400/webrev/" class="">http://cr.openjdk.java.net/~tschatzl/8152400/webrev/</a><br class=""></div></div></blockquote><div><br class=""></div>Looks good.<div class=""><br class=""></div><div class="">Per</div><div class=""><br class=""></div><blockquote type="cite" class=""><div class=""><div class="">Testing:<br class="">local testing, local building<br class=""><br class="">Thanks,<br class=""> Thomas<br class=""></div></div></blockquote></div><br class=""></body></html>