<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Stefan,<br>
<br>
Thanks for looking, please find my answers inline.<br>
<br>
<div class="moz-cite-prefix">On 24.03.2016 11:52, Stefan Johansson
wrote:<br>
</div>
<blockquote cite="mid:56F3AADB.1040405@oracle.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<tt>Hi Dima,</tt><br>
<br>
<div class="moz-cite-prefix">On 2016-03-23 18:28, Dmitry Fazunenko
wrote:<br>
</div>
<blockquote cite="mid:56F2D239.2020605@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
Hello,<br>
<br>
may I have a couple of reviews for a quite trivial fix, which
splits up the hotspot_gc jtreg group:<br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Edfazunen/8152422/webrev.00/">http://cr.openjdk.java.net/~dfazunen/8152422/webrev.00/</a><br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8152422">https://bugs.openjdk.java.net/browse/JDK-8152422</a><br>
<br>
The purpose of the split is to parallelize the execution of GC
tests in JPRT.<br>
Running the tests located under the gc/g1 folder takes
approximately the same amount of time as running other tests.<br>
<br>
To reduce the execution time (for ~20%) I propose to remove a
couple of slow tests from JPRT run:<br>
<br>
38,52 : gc/cms/TestMBeanCMS.java (former name
test/gc/6581734/Test6581734.java)<br>
CMS is updating vary rare now, so it's very unlikely to break
the area under this test <br>
<br>
18,05 :
gc/survivorAlignment/TestPromotionFromSurvivorToTenuredAfterMinorGC.java<br>
There will remain 3 very similar tests for survivor
alignment<br>
5,38 :
gc/survivorAlignment/TestPromotionFromEdenToTenured.java<br>
6,47 : gc/survivorAlignment/TestAllocationInEden.java<br>
6,78 :
gc/survivorAlignment/TestPromotionFromSurvivorToTenuredAfterFullGC.java<br>
so dropping this test will not create a gap in testing.<br>
<br>
I also restored test which were excluded from JPRT execution a
year ago:<br>
90,66 : gc/g1/TestGreyReclaimedHumongousObjects.java<br>
the test is the slowest one, but after the split it fits the
budget.<br>
<br>
</blockquote>
I think the proposed change looks good. Really nice that it was
possible to do the split by having one group including all G1
tests. <br>
</blockquote>
Just for the notice, :hotspot_gc_1 contains not all G1 tests.<br>
# All tests that explicitly set the G1 GC<br>
#<br>
needs_g1gc = \<br>
compiler/regalloc/C1ObjectSpillInLogicOp.java \<br>
gc/TestSmallHeap.java \<br>
gc/TestSystemGC.java \<br>
gc/arguments/TestAlignmentToUseLargePages.java \<br>
gc/arguments/TestG1ConcRefinementThreads.java \<br>
gc/arguments/TestG1HeapRegionSize.java \<br>
gc/arguments/TestG1HeapSizeFlags.java \<br>
gc/arguments/TestG1PercentageOptions.java \<br>
gc/arguments/TestMaxHeapSizeTools.java \<br>
gc/arguments/TestMaxNewSize.java \<br>
gc/arguments/TestParallelGCThreads.java \<br>
gc/arguments/TestUseCompressedOopsErgo.java \<br>
gc/class_unloading/TestG1ClassUnloadingHWM.java \<br>
gc/ergonomics/TestDynamicNumberOfGCThreads.java \<br>
gc/g1/ \<br>
gc/logging/TestGCId.java \<br>
gc/metaspace/G1AddMetaspaceDependency.java \<br>
gc/metaspace/TestMetaspacePerfCounters.java \<br>
gc/startup_warnings/TestG1.java \<br>
gc/whitebox/TestConcMarkCycleWB.java <br>
<br>
<br>
<blockquote cite="mid:56F3AADB.1040405@oracle.com" type="cite"> <br>
One improvement I would like, is to leave the group hotspot_gc and
define it as :hotspot_gc_1 and :hotspot_gc_2. This would be nice
when running RBT for example. <br>
</blockquote>
<br>
I was thinking about adding such group, but I came to the conclusion
that such group is not needed. Groups are needed for JPRT only, RBT
users can specify hotspot/test/gc to run all gc tests.<br>
<br>
Thanks,<br>
Dima<br>
<br>
<br>
<blockquote cite="mid:56F3AADB.1040405@oracle.com" type="cite"> <br>
Thanks,<br>
Stefan<br>
<br>
<blockquote cite="mid:56F2D239.2020605@oracle.com" type="cite"> If
someone has objections on adding/removing JPRT tests, please
speak up.<br>
<br>
Thanks, <br>
Dima<br>
<br>
PS:<br>
The new statistics (taken from
linux_i586_3.8-fastdebug-c1-hotspot_gc_*.log) now looks like:<br>
<b>:hotspot_gc_1</b><b><br>
</b> 0,12 : gc/g1/TestShrinkAuxiliaryData25.java<br>
0,14 : gc/g1/TestShrinkAuxiliaryData05.java<br>
0,21 : gc/g1/TestShrinkAuxiliaryData10.java<br>
0,21 : gc/g1/TestShrinkAuxiliaryData15.java<br>
0,23 : gc/g1/TestShrinkAuxiliaryData30.java<br>
0,28 : gc/g1/TestShrinkToOneRegion.java<br>
0,31 : gc/g1/TestStringSymbolTableStats.java<br>
0,38 : gc/g1/TestRegionAlignment.java<br>
0,43 : gc/g1/TestStringDeduplicationInterned.java<br>
0,45 : gc/g1/TestHumongousAllocInitialMark.java<br>
0,54 : gc/g1/TestShrinkAuxiliaryData20.java<br>
0,55 : gc/g1/TestRegionLivenessPrint.java<br>
0,63 : gc/g1/TestNoEagerReclaimOfHumongousRegions.java<br>
0,64 : gc/g1/TestHumongousAllocNearlyFullRegion.java<br>
0,67 : gc/g1/TestRemsetLoggingPerRegion.java<br>
0,68 : gc/g1/humongousObjects/TestObjectCollected.java<br>
0,77 : gc/g1/TestStringDeduplicationFullGC.java<br>
0,80 : gc/g1/Test2GbHeap.java<br>
0,82 : gc/g1/TestPLABOutput.java<br>
0,86 : gc/g1/TestPrintRegionRememberedSetInfo.java<br>
0,93 : gc/g1/TestStringDeduplicationTableResize.java<br>
0,94 : gc/g1/TestHumongousShrinkHeap.java<br>
0,95 : gc/g1/humongousObjects/TestHumongousMovement.java<br>
1,00 : gc/g1/TestShrinkAuxiliaryData00.java<br>
1,02 : gc/g1/TestStringDeduplicationTableRehash.java<br>
1,02 : gc/g1/TestStringDeduplicationYoungGC.java<br>
1,05 : gc/g1/TestRemsetLoggingThreads.java<br>
1,17 : gc/g1/TestShrinkDefragmentedHeap.java<br>
1,37 : gc/g1/TestStringDeduplicationPrintOptions.java<br>
1,48 : gc/g1/TestGCLogMessages.java<br>
1,94 : gc/g1/TestStringDeduplicationAgeThreshold.java<br>
2,21 : gc/g1/TestPLABSizeBounds.java<br>
2,36 : gc/g1/TestLargePageUseForAuxMemory.java<br>
2,72 :
gc/g1/TestEagerReclaimHumongousRegionsWithRefs.java<br>
2,85 : gc/g1/TestEagerReclaimHumongousRegions.java<br>
2,87 : gc/g1/TestG1TraceEagerReclaimHumongousObjects.java<br>
2,88 : gc/g1/TestRemsetLogging.java<br>
3,57 : gc/g1/plab/TestPLABResize.java<br>
8,26 : gc/g1/humongousObjects/TestHeapCounters.java<br>
8,72 : gc/g1/humongousObjects/TestHumongousThreshold.java<br>
10,95 : gc/g1/TestHumongousCodeCacheRoots.java<br>
14,49 : gc/g1/plab/TestPLABPromotion.java<br>
52,17 :
gc/g1/TestEagerReclaimHumongousRegionsClearMarkBits.java<br>
59,11 :
gc/g1/humongousObjects/TestHumongousNonArrayAllocation.java<br>
90,66 : gc/g1/TestGreyReclaimedHumongousObjects.java<br>
SUMMARY: <br>
Totat tests: 45<br>
Totat time: 4m 46s<br>
<br>
<b>:hotspot_gc_2</b><b><br>
</b> 0,08 : gc/arguments/TestCompressedClassFlags.java<br>
0,09 : gc/startup_warnings/TestDefNewCMS.java<br>
0,20 : gc/startup_warnings/TestParNewSerialOld.java<br>
0,21 : gc/arguments/TestUseNUMAInterleaving.java<br>
0,28 :
gc/startup_warnings/TestParallelScavengeSerialOld.java<br>
0,28 : gc/startup_warnings/TestParallelGC.java<br>
0,29 : gc/startup_warnings/TestParNewCMS.java<br>
0,30 : gc/logging/TestPrintReferences.java<br>
0,30 : gc/startup_warnings/TestG1.java<br>
0,30 : gc/cms/TestCMSScavengeBeforeRemark.java<br>
0,31 : gc/TestVerifyDuringStartup.java<br>
0,32 : gc/startup_warnings/TestSerialGC.java<br>
0,33 : gc/TestVerifySubSet.java<br>
0,37 : gc/TestNUMAPageSize.java<br>
0,37 : sanity/ExecuteInternalVMTests.java<br>
0,37 : gc/metaspace/TestMetaspaceInitialization.java<br>
0,41 : gc/whitebox/TestWBGC.java<br>
0,47 : gc/arguments/TestSelectDefaultGC.java<br>
0,47 : gc/TestVerifySilently.java<br>
0,50 :
gc/arguments/TestUnrecognizedVMOptionsHandling.java<br>
0,51 : gc/startup_warnings/TestCMS.java<br>
0,53 : gc/arguments/TestG1ConcMarkStepDurationMillis.java<br>
0,53 : gc/arguments/TestNewSizeThreadIncrease.java<br>
0,60 : gc/arguments/TestG1ConcRefinementThreads.java<br>
0,67 : gc/arguments/TestG1HeapRegionSize.java<br>
0,77 : gc/arguments/TestArrayAllocatorMallocLimit.java<br>
0,80 : gc/class_unloading/TestG1ClassUnloadingHWM.java<br>
0,80 : gc/TestFullGCCount.java<br>
0,80 : gc/arguments/TestG1PercentageOptions.java<br>
0,89 : gc/arguments/TestHeapFreeRatio.java<br>
0,94 : gc/parallel/AdaptiveGCBoundary.java<br>
0,97 :
gc/arguments/TestSurvivorAlignmentInBytesOption.java<br>
0,97 : gc/logging/TestGCId.java<br>
1,01 : gc/logging/TestDeprecatedPrintFlags.java<br>
1,03 : gc/TestCardTablePageCommits.java<br>
1,08 : gc/arguments/TestInitialTenuringThreshold.java<br>
1,10 : gc/metaspace/TestPerfCountersAndMemoryPools.java<br>
1,21 : gc/metaspace/TestMetaspaceSizeFlags.java<br>
1,26 : gc/arguments/TestUseCompressedOopsErgo.java<br>
1,30 : gc/TestDisableExplicitGC.java<br>
1,57 :
gc/class_unloading/TestCMSClassUnloadingEnabledHWM.java<br>
1,62 : gc/whitebox/TestConcMarkCycleWB.java<br>
1,71 : gc/serial/HeapChangeLogging.java<br>
1,73 : gc/arguments/TestVerifyBeforeAndAfterGCFlags.java<br>
1,86 : gc/metaspace/TestCapacityUntilGCWrapAround.java<br>
1,88 : gc/metaspace/TestMetaspaceMemoryPool.java<br>
1,91 : gc/TestSoftReferencesBehaviorOnOOME.java<br>
2,06 : gc/TestSmallHeap.java<br>
2,15 : gc/metaspace/G1AddMetaspaceDependency.java<br>
2,15 : gc/arguments/TestParallelGCThreads.java<br>
2,16 : gc/arguments/TestAlignmentToUseLargePages.java<br>
2,18 : gc/arguments/TestDynMinHeapFreeRatio.java<br>
2,18 : gc/TestSystemGC.java<br>
2,35 : gc/arguments/TestDynMaxHeapFreeRatio.java<br>
2,36 : gc/parallel/TestPrintGCDetailsVerbose.java<br>
2,38 : gc/ergonomics/TestDynamicNumberOfGCThreads.java<br>
2,40 : gc/TestObjectAlignment.java<br>
2,53 : gc/parallel/TestDynShrinkHeap.java<br>
2,56 : gc/cms/GuardShrinkWarning.java<br>
2,59 : gc/arguments/TestSerialHeapSizeFlags.java<br>
2,59 : gc/arguments/TestG1HeapSizeFlags.java<br>
2,64 : gc/arguments/TestNewRatioFlag.java<br>
2,64 : gc/arguments/TestParallelHeapSizeFlags.java<br>
2,77 : gc/cms/TestBubbleUpRef.java<br>
2,78 : gc/arguments/TestCMSHeapSizeFlags.java<br>
3,60 : gc/arguments/TestObjectTenuringFlags.java<br>
4,34 :
gc/survivorAlignment/TestPromotionFromEdenToTenured.java<br>
4,57 :
gc/arguments/TestMinAndInitialSurvivorRatioFlags.java<br>
4,64 : gc/survivorAlignment/TestAllocationInEden.java<br>
4,84 : gc/TestBigObj.java<br>
5,19 : gc/arguments/TestNewSizeFlags.java<br>
5,19 : gc/arguments/TestMinInitialErgonomics.java<br>
6,18 :
gc/survivorAlignment/TestPromotionFromSurvivorToTenuredAfterFullGC.java<br>
6,63 : gc/arguments/TestTargetSurvivorRatioFlag.java<br>
6,63 : gc/CondCardMark/Basic.java<br>
7,15 : gc/arguments/TestMaxNewSize.java<br>
7,63 : gc/arguments/TestSurvivorRatioFlag.java<br>
10,69 : gc/metaspace/TestMetaspacePerfCounters.java<br>
14,45 : gc/cms/DisableResizePLAB.java<br>
27,59 : gc/arguments/TestShrinkHeapInSteps.java<br>
40,39 : gc/arguments/TestMaxMinHeapFreeRatioFlags.java<br>
SUMMARY: <br>
Totat tests: 81<br>
Totat time: 3m 59s<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>