<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi Mikael, Tom,<br>
<br>
On 4/8/16 12:09 PM, Tom Benson wrote:<br>
</div>
<blockquote cite="mid:5707D7CD.9030005@oracle.com" type="cite">Hi
Mikael,
<br>
It looks like there is an indentation problem at lines 214/215.
<br>
Dumb question: The code now extends the range down to the object
start, if current region continues_humongous. Do you want to
extend to the true end region of the object, which might not be
the current one?
<br>
Tom
<br>
</blockquote>
<br>
Tom, <br>
<br>
I don't think this is extending the range to the start of the HR,
it's just checking the mark bit at the start of the HR. Not that I'm
following why we're marking all of the live bytes instead of just
relying on the mark for the start of the object, but it looks like
that's what we do :-)<br>
<br>
<br>
Mikael,<br>
<br>
It looks like the
<meta http-equiv="content-type" content="text/html; charset=utf-8">
humongous_start_region() of a "starts_humongous" region is itself,
so you can remove lines 210 + 212, and merge 209 + 211.<br>
<br>
Looks good otherwise.<br>
<br>
- Derek<br>
<blockquote cite="mid:5707D7CD.9030005@oracle.com" type="cite">On
4/8/2016 11:47 AM, Mikael Gerdin wrote:
<br>
<blockquote type="cite">Hi all,
<br>
<br>
Please review this small change to solve an integration blocker
in hs-rt which surfaced with the latest integration from main.
<br>
<br>
The problem is that humongous regions are kept around for longer
(possibly indefinitely) because the card live data helper
unconditionally sets the actual size of humongous objects
instead of the number of live bytes. Having a non-zero live
bytes count prevents the cleanup pause from freeing the
humongous objects.
<br>
When the next gc pause then tries to register those objects with
eager reclaim it looks at the class pointer of the object and if
the class of the humongous object was unloaded then we crash.
<br>
<br>
Bug: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8153843">https://bugs.openjdk.java.net/browse/JDK-8153843</a>
<br>
Webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~mgerdin/8153843/webrev.0/">http://cr.openjdk.java.net/~mgerdin/8153843/webrev.0/</a>
<br>
Testing: Crashing testcase, JPRT job running
<br>
<br>
Thanks
<br>
/Mikael
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>