<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 4/12/16 12:40 PM, Derek White wrote:<br>
</div>
<blockquote cite="mid:570D24EE.8060806@oracle.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<div class="moz-cite-prefix">On 4/12/16 8:57 AM, Mikael Gerdin
wrote:<br>
</div>
<blockquote cite="mid:570CF09E.6010805@oracle.com" type="cite">Hi
Derek, Tom <br>
<br>
Are you planning to re-review webrev.1 or can I push this? <br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Emgerdin/8153843/webrev.1/">http://cr.openjdk.java.net/~mgerdin/8153843/webrev.1/</a>
<br>
<br>
/Mikael <br>
</blockquote>
<br>
Hi Mikael,<br>
<br>
My only question is about the issue Thomas pointed out and you
fixed:<br>
g1CollectedHeap.cpp, Line 2946.<br>
<br>
I am surprised that "Dead objects cannot be eager reclaim
candidates" - I thought they were the perfect eager reclaim
candidates. Should it be that we simply declare victory and return
true at line 2951 (bypassing the unsafe stuff)?<br>
</blockquote>
<br>
OK, answering my own question :-)<br>
- Derek, please read the big block comment. If the object is dead
we can't prove all of the constraints listed are satisfied.<br>
<br>
But it might be a good idea to tag humongous regions that don't
contain references at humongous object allocation time. Then we
should be able to do eager reclaim without looking at the Klass.<br>
<br>
reviewed.<br>
<br>
- Derek<br>
<blockquote cite="mid:570D24EE.8060806@oracle.com" type="cite"> <br>
Otherwise everything looks fine to me.<br>
<br>
Thanks,<br>
<br>
- Derek<br>
</blockquote>
<br>
</body>
</html>