<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Ramki and Jon,<br>
<br>
What's the status of this review thread? The bug is still open and
targeted for JDK 9.<br>
<br>
Thanks,<br>
StefanK<br>
<br>
<div class="moz-cite-prefix">On 2015-06-03 08:15, Srinivas
Ramakrishna wrote:<br>
</div>
<blockquote
cite="mid:E638F899-02C6-415E-9729-247B4D03DD01@gmail.com"
type="cite">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<div>Thanks Jon for the review and the pointer to the test. I'll
get back to you later this week with a suitable test.</div>
<div><br>
</div>
<div>-- Ramki<br>
<br>
ysr1729</div>
<div><br>
On Jun 2, 2015, at 14:16, Jon Masamitsu <<a
moz-do-not-send="true" href="mailto:jon.masamitsu@oracle.com"><a class="moz-txt-link-abbreviated" href="mailto:jon.masamitsu@oracle.com">jon.masamitsu@oracle.com</a></a>>
wrote:<br>
<br>
</div>
<blockquote type="cite">
<div>
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
Ramki,<br>
<br>
Changes look good.<br>
<br>
I'm guessing you tested by generating the<br>
perfdata by hand and verifying the contents<br>
of the perfdata. Do you think a test can<br>
be written to verify the change? If you look at<br>
<br>
test/gc/metaspace/TestMetaspacePerfCounters.java<br>
<br>
in your repository I think that is an example that <br>
can be followed.<br>
<br>
It's a jtreg test.<br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://openjdk.java.net/jtreg/">http://openjdk.java.net/jtreg/</a><br>
<br>
Jon<br>
<br>
<div class="moz-cite-prefix">On 06/01/2015 11:39 AM, Srinivas
Ramakrishna wrote:<br>
</div>
<blockquote
cite="mid:CABzyjykXBFWLg0iY9eG6D4b4bOHbPsQ0=34KHrMOeufB0in7JA@mail.gmail.com"
type="cite">
<div dir="ltr">Thanks for the review of the patch for 8-dev
(from the ticket), Staffan.
<div><br>
</div>
<div>Sorry for the delay in getting the official webrev
out -- it took me a while to first get set up with an
hs9 repo (thanks Jon!) and then get my openjdk
credentials updated (thanks Mark!).
<div><br>
</div>
<div>Here's the webrev against hs9 for official review:-</div>
<div><br>
</div>
<div><a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Eysr/JDK-8080345/webrev.00/">http://cr.openjdk.java.net/~ysr/JDK-8080345/webrev.00/</a><br>
</div>
<div><br>
</div>
<div>I built and tested the change (on both 8-dev whose
patch was attached with the original bug, as well as
this with hs9) and verified that the counter value for
generations, in the perfdata file, was now 2 instead
of the previous 3.</div>
<div><br>
</div>
<div>thanks!</div>
<div>-- ramki</div>
<div><br>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Mon, May 18, 2015 at 1:22
AM, Staffan Larsen <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:staffan.larsen@oracle.com"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:staffan.larsen@oracle.com">staffan.larsen@oracle.com</a></a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">Looks like a
good patch to me.<span class="HOEnZb"><font
color="#888888">
<div><br>
</div>
<div>/Staffan</div>
</font></span>
<div>
<div class="h5">
<div><br>
<div>
<blockquote type="cite">
<div>On 14 maj 2015, at 18:12,
Srinivas Ramakrishna <<a
moz-do-not-send="true"
href="mailto:ysr1729@gmail.com"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:ysr1729@gmail.com">ysr1729@gmail.com</a></a>>
wrote:</div>
<br>
<div>
<div dir="ltr"><a
moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8080345"
style="font-size:13px"
target="_blank"><a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8080345">https://bugs.openjdk.java.net/browse/JDK-8080345</a></a><br>
<div><br>
</div>
<div><br>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed,
May 13, 2015 at 1:08 PM,
Srinivas Ramakrishna <span
dir="ltr"><<a
moz-do-not-send="true"
href="mailto:ysr1729@gmail.com"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:ysr1729@gmail.com">ysr1729@gmail.com</a></a>></span>
wrote:<br>
<blockquote
class="gmail_quote"
style="margin:0 0 0
.8ex;border-left:1px #ccc
solid;padding-left:1ex">
<div dir="ltr"><br>
<div>With perm gen going
away (and being replaced
by metaspace) in JDK 8,
it makes sense that the
counter</div>
<div>sun.gc.policy.generations
should be "2", rather
than "3". However, in
JDK 8 that counter still
says 3.</div>
<div>As I understand, the
intention was that this
counter would allow you
to (for example) know
the range of</div>
<div>the
sun.gc.generation.$num.*
counters describing each
of $num <
sun.gc.policy.generations
in the heap.</div>
<div>Recall that the
erstwhile perm gen in
JDK 7 used to be
synonymous with
sun.gc.generation.2, but
the</div>
<div>JDK 8 avatars are now
sun.gc.metaspace and
sun.gc.compressedclassspace.</div>
<div><br>
</div>
<div>The fix is simple,
and I can submit a
patch. Is there an
existing bug for this?</div>
<div><br>
</div>
<div>thanks!</div>
<div>-- ramki</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
<br>
</div>
</blockquote>
</blockquote>
<br>
</body>
</html>