<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Jon,<br>
<br>
<div class="moz-cite-prefix">On 2016-04-14 19:15, Jon Masamitsu
wrote:<br>
</div>
<blockquote cite="mid:570FD03B.7020300@oracle.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<br>
<br>
<div class="moz-cite-prefix">On 04/14/2016 02:00 AM, Stefan
Karlsson wrote:<br>
</div>
<blockquote cite="mid:570F5C3E.4090904@oracle.com" type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
Hi Jon,<br>
<br>
<div class="moz-cite-prefix">On 2016-04-13 20:40, Jon Masamitsu
wrote:<br>
</div>
<blockquote cite="mid:570E9295.3080908@oracle.com" type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
<font face="Times New Roman, Times, serif">Stefan,<br>
<br>
Is the cause of this problem that there should be better
argument checking on<br>
LargePageSizeInBytes?<br>
</font></blockquote>
<br>
I think the cause is that I made some incorrect assumptions when
I wrote the unit test.<br>
<br>
But yes, restricting the LargePageSizeInBytes on solaris would
also solve the problem. I could make that change, but it
probably requires a CCC approval, since it changes the behavior
of a product flag.<br>
<br>
</blockquote>
<br>
I understand. I'll create a CR to improve the argument checking
on<br>
LargePageSizeInBytes. Your change is correct.<br>
<br>
Reviewed.<br>
</blockquote>
<br>
Thanks!<br>
<br>
StefanK<br>
<br>
<blockquote cite="mid:570FD03B.7020300@oracle.com" type="cite"> <br>
Jon<br>
<br>
<blockquote cite="mid:570F5C3E.4090904@oracle.com" type="cite">
StefanK<br>
<br>
<blockquote cite="mid:570E9295.3080908@oracle.com" type="cite"><font
face="Times New Roman, Times, serif"> <br>
Jon<br>
</font><br>
<div class="moz-cite-prefix">On 04/13/2016 02:21 AM, Stefan
Karlsson wrote:<br>
</div>
<blockquote cite="mid:570E0F95.1020208@oracle.com" type="cite">Hi
all, <br>
<br>
Please review this small patch to fix a unit test problem
when running tests with -XX:LargePageSizeInBytes=<small
page size>. <br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Estefank/8053885/webrev.01/">http://cr.openjdk.java.net/~stefank/8053885/webrev.01/</a>
<br>
<br>
The problem was easily reproducible with the following
command line on solaris sparc: <br>
java -XX:LargePageSizeInBytes=8192
-XX:+ExecuteInternalVMTests -version <br>
<br>
# Internal Error
(/opt/jprt/T/P1/215954.amurillo/s/hotspot/src/share/vm/memory/metaspace.cpp:1204),
pid=5652, tid=5668 <br>
# assert(is_size_aligned(vs_byte_size,
Metaspace::reserve_alignment())) failed: 32768 is not
aligned to 2097152 <br>
<br>
Thanks, <br>
StefanK <br>
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>