<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Jon,<br>
<br>
<div class="moz-cite-prefix">On 21.04.2016 1:13, Jon Masamitsu
wrote:<br>
</div>
<blockquote cite="mid:5717FF06.6070405@oracle.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<br>
<br>
<div class="moz-cite-prefix">On 04/20/2016 09:53 AM, Michail
Chernov wrote:<br>
</div>
<blockquote cite="mid:5717B411.5000705@oracle.com" type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
HI Jon,<br>
<br>
This is the way to remove new unified logging options, like
-Xlog:all=trace or -Xlog:gc*=trace. Tests define -Xlog:...
inside for checking,</blockquote>
Sorry, but I still don't understand. "Tests define -Xlog:..."
means that the tests<br>
have built into them unified logging style flags?<br>
</blockquote>
<br>
Michail used not proper wording "will conflict". The flags of the
tests and possible external -Xlog flags will not conflict, but the
test might fail, if external options turn more logging on.<br>
The fix protects the test from extra logging.<br>
<br>
Michail, the fix looks good to me.<br>
<br>
Thanks,<br>
Dima<br>
<br>
<br>
<br>
<blockquote cite="mid:5717FF06.6070405@oracle.com" type="cite"> <br>
Jon<br>
<br>
<blockquote cite="mid:5717B411.5000705@oracle.com" type="cite">
new GC baseline will conflict with these tests, so filtering of
-Xlog* will allow us to run these tests in that new nightly
testing.<br>
<br>
Michail<br>
<br>
<div class="moz-cite-prefix">On 20.04.2016 19:22, Jon Masamitsu
wrote:<br>
</div>
<blockquote cite="mid:5717ACCF.3090703@oracle.com" type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
<font face="Times New Roman, Times, serif">Michail,<br>
<br>
Is this the common way of dealing with obsolete command line
flags? To<br>
filter them out instead of removing the obsolete flags?<br>
<br>
Jon<br>
</font><br>
<div class="moz-cite-prefix">On 04/20/2016 09:03 AM, Michail
Chernov wrote:<br>
</div>
<blockquote cite="mid:5717A858.7060509@oracle.com" type="cite">Hi,
<br>
<br>
Could I have a reviews for this small change please. <br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8154759">https://bugs.openjdk.java.net/browse/JDK-8154759</a>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Emchernov/8154759/webrev.00/">http://cr.openjdk.java.net/~mchernov/8154759/webrev.00/</a>
<br>
<br>
Tests now filter out -Xlog* option. This is needed because
we are going to extend GC nightly by adding -Xlog:all=trace
to default GC baseline to check unified gc logging (<a
moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8150845"><a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8150845">https://bugs.openjdk.java.net/browse/JDK-8150845</a></a>).
<br>
<br>
Thanks <br>
Michail <br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>