<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 05/02/2016 05:40 AM, Mikael Gerdin
wrote:<br>
</div>
<blockquote cite="mid:57274ACC.5040707@oracle.com" type="cite">Hi,
<br>
<br>
Please review this change to clean out unused code from
SurvRateGroup. The G1YoungSurvRateNumRegionsSummary flag is only
accessible in notproduct builds and it is my opinion that the
ability to print the predicted aggregate survivor rates for eden
regions at JVM shutdown is not a particularly useful feature.
<br>
<br>
Testing: Local testing with gc test suite.
<br>
Bug: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8155634">https://bugs.openjdk.java.net/browse/JDK-8155634</a>
<br>
Webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~mgerdin/8155634/webrev.0/">http://cr.openjdk.java.net/~mgerdin/8155634/webrev.0/</a>
<br>
</blockquote>
<br>
<font face="Times New Roman, Times, serif">Mikael,<br>
<br>
Changes look good.<br>
<br>
I don't have much of an opinion on whether the survivor rate
summary is<br>
useful but I note that<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~mgerdin/8155634/webrev.0/src/share/vm/gc/g1/g1CollectedHeap.cpp.udiff.html">http://cr.openjdk.java.net/~mgerdin/8155634/webrev.0/src/share/vm/gc/g1/g1CollectedHeap.cpp.udiff.html</a><br>
</font>
<pre> void G1CollectedHeap::print_tracing_info() const {
g1_rem_set()->print_summary_info();
concurrent_mark()->print_summary_info();
<span class="removed">- g1_policy()->print_yg_surv_rate_info();</span>
}
the remembered set and concurrent marking summaries are being kept.
Can you explain why survivor rate is the exception? All seems to
me averages over such an extended period that they all deserve the
same fate.
Thanks.
Jon
</pre>
<br>
<blockquote cite="mid:57274ACC.5040707@oracle.com" type="cite">
<br>
/Mikael
<br>
</blockquote>
<br>
</body>
</html>