<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Dmitry,<br>
<br>
Thank you for review!<br>
Regards, Kirill<br>
<br>
<div class="moz-cite-prefix">On 05/11/2016 02:07 PM, Dmitry
Fazunenko wrote:<br>
</div>
<blockquote
cite="mid:aef596e5-a9c1-0b21-a983-3a1e343d682d@oracle.com"
type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
Hi Kirill,<br>
<br>
The fix looks good to me.<br>
One minor suggestion:<br>
<pre>-Xlog:gc=
-->
-Xlog:gc*=
</pre>
In case of failure the more data available the better.<br>
(I don't need a separate review for that change).<br>
<br>
<br>
Thanks,<br>
Dima<br>
<br>
<br>
<div class="moz-cite-prefix">On 11.05.2016 13:42, Kirill
Zhaldbybin wrote:<br>
</div>
<blockquote cite="mid:57330C7E.5020703@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
<font size="-1">Dear all,<br>
<br>
Could you please review this fix for 8132713?<br>
<br>
This fix adds two CMC scenarios to
gc/g1/humongousObjects/objectGraphTest/TestObjectGraphAfterGC.java
which creates different types of object graphs with Object
arrays as nodes (to make them humongous) and checks that after
different types GCs objects' graphs were handled correctly.<br>
<br>
During first CMC scenario the test expects that weakly
reachable non-humongous nodes which are not referenced by
weakly reachable humongous nodes should be collected and other
weakly reachable nodes should not be collected (since weakly
reachable non-humongous nodes are in young gen and during CMC
they are handled as strong roots).<br>
During second CMC scenario the test expects that all weakly
reachable nodes should be collected since non-humongous nodes
were previously promoted to old gen.<br>
During both scenarios softly reachable nodes should not be
collected.<br>
<br>
WebRev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ekzhaldyb/webrevs/JDK-8132713/webrev.00/">http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8132713/webrev.00/</a><br>
CR: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8132713">https://bugs.openjdk.java.net/browse/JDK-8132713</a><br>
<br>
Thank you.<br>
<br>
Regards, Kirill<br>
</font> </blockquote>
<br>
</blockquote>
<br>
</body>
</html>