<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi Kim,<br>
<br>
On 5/24/16 12:59 PM, Kim Barrett wrote:<br>
</div>
<blockquote
cite="mid:AD718E8B-CA64-46F7-BDAF-A59ADEC811C0@oracle.com"
type="cite">
<blockquote type="cite">
<pre wrap="">On May 22, 2016, at 10:01 PM, Jon Masamitsu <a class="moz-txt-link-rfc2396E" href="mailto:jon.masamitsu@oracle.com"><jon.masamitsu@oracle.com></a> wrote:
On 5/20/2016 2:24 PM, Kim Barrett wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Please review this fix for a serious performance bug in non-product
verification code in CMS precleaning.
</pre>
</blockquote>
<pre wrap="">
Instead of eliminate the verification can you leave it in for non-object arrays?
You might be able to do the verification for the object array once if you did it
only when an object header was in the dirty range but do it for the length of
the entire object array.
</pre>
</blockquote>
<pre wrap="">
It is possible, and even fairly likely, that the objArray's header is
not in any relevant dirty range.
</pre>
<blockquote type="cite">
<pre wrap="">If the verification were to consistently fail here and never fail when done during
the sweep, I think that bounds where in the code we need to look for a problem.
</pre>
</blockquote>
<pre wrap="">
That doesn't seem like a very likely scenario to me; timing
differences between runs could easily result in problems being missed
until the sweep phase.
OTOH, having spent some time studying old bug reports, I now agree the
Printezis-bit consistency checks there have real value, and will
reinstate them.
I'm less convinced about the utility of the interior mark bit
verification there. However, there's a way to mostly keep it, while
strongly reducing the performance impact. The idea is to record the
last verified object and only perform the verification if the new
object differs from that last verified. So I'll do that too.
New webrev:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~kbarrett/8156548/webrev.01/">http://cr.openjdk.java.net/~kbarrett/8156548/webrev.01/</a>
(No incremental webrev, since this version is pretty much completely
different.)
Testing:
Redid local testing to verify performance benefit.
RBT GC testing with CMS as the collector.
</pre>
</blockquote>
<p>Looks good. reviewed.</p>
<p>Only nits are copyrights in:</p>
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
<blockquote>vm/gc/cms/concurrentMarkSweepGeneration.hpp<br>
vm/opto/macroArrayCopy.cpp<br>
<br>
</blockquote>
Don't need to see any revs for this.<br>
<br>
- Derek<br>
</body>
</html>